| Message ID | 20230523061546.49031-1-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hw/ppc/openpic: Do not open-code ROUND_UP() macro | expand |
On 5/22/23 23:15, Philippe Mathieu-Daudé wrote: > While reviewing, the ROUND_UP() macro is easier to figure out. > Besides, the comment confirms we want to round up here. > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > include/hw/ppc/openpic.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 23/05/2023 07:15, Philippe Mathieu-Daudé wrote: > While reviewing, the ROUND_UP() macro is easier to figure out. > Besides, the comment confirms we want to round up here. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > include/hw/ppc/openpic.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/ppc/openpic.h b/include/hw/ppc/openpic.h > index ebdaf8a493..bae8dafe16 100644 > --- a/include/hw/ppc/openpic.h > +++ b/include/hw/ppc/openpic.h > @@ -55,7 +55,7 @@ typedef enum IRQType { > * Round up to the nearest 64 IRQs so that the queue length > * won't change when moving between 32 and 64 bit hosts. > */ > -#define IRQQUEUE_SIZE_BITS ((OPENPIC_MAX_IRQ + 63) & ~63) > +#define IRQQUEUE_SIZE_BITS ROUND_UP(OPENPIC_MAX_IRQ, 64) > > typedef struct IRQQueue { > unsigned long *queue; Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> ATB, Mark.
There is no generic PPC section in MAINTAINERS covering include/hw/ppc/, so Cc'ing qemu-ppc@ manually. Daniel, can you take this (reviewed) patch? Thanks, Phil. On 23/5/23 08:15, Philippe Mathieu-Daudé wrote: > While reviewing, the ROUND_UP() macro is easier to figure out. > Besides, the comment confirms we want to round up here. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > include/hw/ppc/openpic.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/ppc/openpic.h b/include/hw/ppc/openpic.h > index ebdaf8a493..bae8dafe16 100644 > --- a/include/hw/ppc/openpic.h > +++ b/include/hw/ppc/openpic.h > @@ -55,7 +55,7 @@ typedef enum IRQType { > * Round up to the nearest 64 IRQs so that the queue length > * won't change when moving between 32 and 64 bit hosts. > */ > -#define IRQQUEUE_SIZE_BITS ((OPENPIC_MAX_IRQ + 63) & ~63) > +#define IRQQUEUE_SIZE_BITS ROUND_UP(OPENPIC_MAX_IRQ, 64) > > typedef struct IRQQueue { > unsigned long *queue;
On 5/23/23 03:15, Philippe Mathieu-Daudé wrote: > While reviewing, the ROUND_UP() macro is easier to figure out. > Besides, the comment confirms we want to round up here. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel > include/hw/ppc/openpic.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/ppc/openpic.h b/include/hw/ppc/openpic.h > index ebdaf8a493..bae8dafe16 100644 > --- a/include/hw/ppc/openpic.h > +++ b/include/hw/ppc/openpic.h > @@ -55,7 +55,7 @@ typedef enum IRQType { > * Round up to the nearest 64 IRQs so that the queue length > * won't change when moving between 32 and 64 bit hosts. > */ > -#define IRQQUEUE_SIZE_BITS ((OPENPIC_MAX_IRQ + 63) & ~63) > +#define IRQQUEUE_SIZE_BITS ROUND_UP(OPENPIC_MAX_IRQ, 64) > > typedef struct IRQQueue { > unsigned long *queue;
diff --git a/include/hw/ppc/openpic.h b/include/hw/ppc/openpic.h index ebdaf8a493..bae8dafe16 100644 --- a/include/hw/ppc/openpic.h +++ b/include/hw/ppc/openpic.h @@ -55,7 +55,7 @@ typedef enum IRQType { * Round up to the nearest 64 IRQs so that the queue length * won't change when moving between 32 and 64 bit hosts. */ -#define IRQQUEUE_SIZE_BITS ((OPENPIC_MAX_IRQ + 63) & ~63) +#define IRQQUEUE_SIZE_BITS ROUND_UP(OPENPIC_MAX_IRQ, 64) typedef struct IRQQueue { unsigned long *queue;
While reviewing, the ROUND_UP() macro is easier to figure out. Besides, the comment confirms we want to round up here. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- include/hw/ppc/openpic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)