diff mbox series

[v2,1/2] drm/msm/dsi: remove extra call to dsi_get_pclk_rate()

Message ID 20230520200103.4019607-1-dmitry.baryshkov@linaro.org
State Superseded
Headers show
Series [v2,1/2] drm/msm/dsi: remove extra call to dsi_get_pclk_rate() | expand

Commit Message

Dmitry Baryshkov May 20, 2023, 8:01 p.m. UTC 
In dsi_calc_clk_rate_v2() there is no need to call dsi_get_pclk_rate().
This function has just been called (from dsi_calc_pclk()) and its
result is stored at msm_host->pixel_clk_rate. Use this variable
directly.

Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---

Changes since v1:
 - Fix typos in commit message (Marijn)

---
 drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Baryshkov June 4, 2023, 3:01 a.m. UTC | #1 
On Sat, 20 May 2023 23:01:02 +0300, Dmitry Baryshkov wrote:
> In dsi_calc_clk_rate_v2() there is no need to call dsi_get_pclk_rate().
> This function has just been called (from dsi_calc_pclk()) and its
> result is stored at msm_host->pixel_clk_rate. Use this variable
> directly.
> 
> 

Applied, thanks!

[1/2] drm/msm/dsi: remove extra call to dsi_get_pclk_rate()
      https://gitlab.freedesktop.org/lumag/msm/-/commit/6de6c28d97c0
[2/2] drm/msm/dsi: use mult_frac for pclk_bpp calculation
      https://gitlab.freedesktop.org/lumag/msm/-/commit/374918d2c396

Best regards,
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 961689a255c4..2b257b459974 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -633,7 +633,7 @@  int dsi_calc_clk_rate_v2(struct msm_dsi_host *msm_host, bool is_bonded_dsi)
 
 	dsi_calc_pclk(msm_host, is_bonded_dsi);
 
-	pclk_bpp = (u64)dsi_get_pclk_rate(msm_host->mode, is_bonded_dsi) * bpp;
+	pclk_bpp = (u64)msm_host->pixel_clk_rate * bpp;
 	do_div(pclk_bpp, 8);
 	msm_host->src_clk_rate = pclk_bpp;