diff mbox

[v2,1/2] example: fix pcap location assumption

Message ID 1463765498-15783-1-git-send-email-mike.holmes@linaro.org
State Accepted
Commit 44cd397e26187106ac4e203790ba6982bf348e3e
Headers show

Commit Message

Mike Holmes May 20, 2016, 5:31 p.m. UTC
Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
v2
  fix broken assumption in existing scripts (Bill)

 example/l2fwd_simple/l2fwd_simple_run.sh | 2 +-
 example/switch/switch_run.sh             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Bill Fischofer May 20, 2016, 7:48 p.m. UTC | #1
For this series:

Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org>

On Fri, May 20, 2016 at 12:31 PM, Mike Holmes <mike.holmes@linaro.org>
wrote:

> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> ---
> v2
>   fix broken assumption in existing scripts (Bill)
>
>  example/l2fwd_simple/l2fwd_simple_run.sh | 2 +-
>  example/switch/switch_run.sh             | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/example/l2fwd_simple/l2fwd_simple_run.sh
> b/example/l2fwd_simple/l2fwd_simple_run.sh
> index 6050360..292d0e3 100755
> --- a/example/l2fwd_simple/l2fwd_simple_run.sh
> +++ b/example/l2fwd_simple/l2fwd_simple_run.sh
> @@ -21,7 +21,7 @@ if [ "$STATUS" -ne 143 ]; then
>    exit 1
>  fi
>
> -if [ `stat -c %s pcapout.pcap` -ne `stat -c %s udp64.pcap` ]; then
> +if [ `stat -c %s pcapout.pcap` -ne `stat -c %s  ${PCAP_IN}` ]; then
>    echo "File sizes disagree"
>    exit 1
>  fi
> diff --git a/example/switch/switch_run.sh b/example/switch/switch_run.sh
> index 9b32973..3f8f9db 100755
> --- a/example/switch/switch_run.sh
> +++ b/example/switch/switch_run.sh
> @@ -33,7 +33,7 @@ fi
>
>  for i in `seq 1 $NUM_RX_PORT`;
>  do
> -       if [ `stat -c %s pcapout${i}.pcap` -ne `stat -c %s udp64.pcap` ];
> then
> +       if [ `stat -c %s pcapout${i}.pcap` -ne `stat -c %s ${PCAP_IN}` ];
> then
>                 echo "Error: Output file $i size not matching"
>                 RETVAL=1
>         fi
> --
> 2.7.4
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
Maxim Uvarov May 23, 2016, 2:47 p.m. UTC | #2
thanks,

Merged.
Maxim.

On 05/20/16 22:48, Bill Fischofer wrote:
> For this series:
>
> Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org>
>
> On Fri, May 20, 2016 at 12:31 PM, Mike Holmes <mike.holmes@linaro.org>
> wrote:
>
>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
>> ---
>> v2
>>    fix broken assumption in existing scripts (Bill)
>>
>>   example/l2fwd_simple/l2fwd_simple_run.sh | 2 +-
>>   example/switch/switch_run.sh             | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/example/l2fwd_simple/l2fwd_simple_run.sh
>> b/example/l2fwd_simple/l2fwd_simple_run.sh
>> index 6050360..292d0e3 100755
>> --- a/example/l2fwd_simple/l2fwd_simple_run.sh
>> +++ b/example/l2fwd_simple/l2fwd_simple_run.sh
>> @@ -21,7 +21,7 @@ if [ "$STATUS" -ne 143 ]; then
>>     exit 1
>>   fi
>>
>> -if [ `stat -c %s pcapout.pcap` -ne `stat -c %s udp64.pcap` ]; then
>> +if [ `stat -c %s pcapout.pcap` -ne `stat -c %s  ${PCAP_IN}` ]; then
>>     echo "File sizes disagree"
>>     exit 1
>>   fi
>> diff --git a/example/switch/switch_run.sh b/example/switch/switch_run.sh
>> index 9b32973..3f8f9db 100755
>> --- a/example/switch/switch_run.sh
>> +++ b/example/switch/switch_run.sh
>> @@ -33,7 +33,7 @@ fi
>>
>>   for i in `seq 1 $NUM_RX_PORT`;
>>   do
>> -       if [ `stat -c %s pcapout${i}.pcap` -ne `stat -c %s udp64.pcap` ];
>> then
>> +       if [ `stat -c %s pcapout${i}.pcap` -ne `stat -c %s ${PCAP_IN}` ];
>> then
>>                  echo "Error: Output file $i size not matching"
>>                  RETVAL=1
>>          fi
>> --
>> 2.7.4
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/example/l2fwd_simple/l2fwd_simple_run.sh b/example/l2fwd_simple/l2fwd_simple_run.sh
index 6050360..292d0e3 100755
--- a/example/l2fwd_simple/l2fwd_simple_run.sh
+++ b/example/l2fwd_simple/l2fwd_simple_run.sh
@@ -21,7 +21,7 @@  if [ "$STATUS" -ne 143 ]; then
   exit 1
 fi
 
-if [ `stat -c %s pcapout.pcap` -ne `stat -c %s udp64.pcap` ]; then
+if [ `stat -c %s pcapout.pcap` -ne `stat -c %s  ${PCAP_IN}` ]; then
   echo "File sizes disagree"
   exit 1
 fi
diff --git a/example/switch/switch_run.sh b/example/switch/switch_run.sh
index 9b32973..3f8f9db 100755
--- a/example/switch/switch_run.sh
+++ b/example/switch/switch_run.sh
@@ -33,7 +33,7 @@  fi
 
 for i in `seq 1 $NUM_RX_PORT`;
 do
-	if [ `stat -c %s pcapout${i}.pcap` -ne `stat -c %s udp64.pcap` ]; then
+	if [ `stat -c %s pcapout${i}.pcap` -ne `stat -c %s ${PCAP_IN}` ]; then
 		echo "Error: Output file $i size not matching"
 		RETVAL=1
 	fi