| Message ID | 1463666014-28131-1-git-send-email-bill.fischofer@linaro.org |
|---|---|
| State | Accepted |
| Commit | 23edd52f14448057186cf320c56f6138c9b9f256 |
| Headers | show |
On 19 May 2016 at 09:53, Bill Fischofer <bill.fischofer@linaro.org> wrote: > Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2220 by removing > unused values. > > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> > Reviewed-and-tested-by: Mike Holmes <mike.holmes@linaro.org> > --- > test/validation/packet/packet.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/test/validation/packet/packet.c > b/test/validation/packet/packet.c > index 7c9622f..bf8d9f4 100644 > --- a/test/validation/packet/packet.c > +++ b/test/validation/packet/packet.c > @@ -1159,7 +1159,7 @@ void packet_test_align(void) > CU_ASSERT(odp_packet_align(&pkt, 0, pkt_len, 0) < 0); > > offset = seg_len - 5; > - pkt_data = odp_packet_offset(pkt, offset, &seg_len, NULL); > + (void)odp_packet_offset(pkt, offset, &seg_len, NULL); > > /* Realign for addressability */ > CU_ASSERT(odp_packet_align(&pkt, offset, > @@ -1167,8 +1167,7 @@ void packet_test_align(void) > > /* Alignment doesn't change packet length or contents */ > CU_ASSERT(odp_packet_len(pkt) == pkt_len); > - aligned_data = odp_packet_offset(pkt, offset, > - &aligned_seglen, NULL); > + (void)odp_packet_offset(pkt, offset, &aligned_seglen, > NULL); > _packet_compare_offset(pkt, offset, > segmented_test_packet, offset, > aligned_seglen); > -- > 2.7.4 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
ping for merge. Needed for RC3 to fix coverity issue. On Thu, May 19, 2016 at 9:09 AM, Mike Holmes <mike.holmes@linaro.org> wrote: > > > On 19 May 2016 at 09:53, Bill Fischofer <bill.fischofer@linaro.org> wrote: > >> Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2220 by removing >> unused values. >> >> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> >> > > Reviewed-and-tested-by: Mike Holmes <mike.holmes@linaro.org> > > >> --- >> test/validation/packet/packet.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/test/validation/packet/packet.c >> b/test/validation/packet/packet.c >> index 7c9622f..bf8d9f4 100644 >> --- a/test/validation/packet/packet.c >> +++ b/test/validation/packet/packet.c >> @@ -1159,7 +1159,7 @@ void packet_test_align(void) >> CU_ASSERT(odp_packet_align(&pkt, 0, pkt_len, 0) < 0); >> >> offset = seg_len - 5; >> - pkt_data = odp_packet_offset(pkt, offset, &seg_len, NULL); >> + (void)odp_packet_offset(pkt, offset, &seg_len, NULL); >> >> /* Realign for addressability */ >> CU_ASSERT(odp_packet_align(&pkt, offset, >> @@ -1167,8 +1167,7 @@ void packet_test_align(void) >> >> /* Alignment doesn't change packet length or contents */ >> CU_ASSERT(odp_packet_len(pkt) == pkt_len); >> - aligned_data = odp_packet_offset(pkt, offset, >> - &aligned_seglen, NULL); >> + (void)odp_packet_offset(pkt, offset, &aligned_seglen, >> NULL); >> _packet_compare_offset(pkt, offset, >> segmented_test_packet, offset, >> aligned_seglen); >> -- >> 2.7.4 >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" > > >
Merged, Maxim. On 05/26/16 00:36, Bill Fischofer wrote: > ping for merge. Needed for RC3 to fix coverity issue. > > On Thu, May 19, 2016 at 9:09 AM, Mike Holmes <mike.holmes@linaro.org> wrote: > >> >> On 19 May 2016 at 09:53, Bill Fischofer <bill.fischofer@linaro.org> wrote: >> >>> Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2220 by removing >>> unused values. >>> >>> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> >>> >> Reviewed-and-tested-by: Mike Holmes <mike.holmes@linaro.org> >> >> >>> --- >>> test/validation/packet/packet.c | 5 ++--- >>> 1 file changed, 2 insertions(+), 3 deletions(-) >>> >>> diff --git a/test/validation/packet/packet.c >>> b/test/validation/packet/packet.c >>> index 7c9622f..bf8d9f4 100644 >>> --- a/test/validation/packet/packet.c >>> +++ b/test/validation/packet/packet.c >>> @@ -1159,7 +1159,7 @@ void packet_test_align(void) >>> CU_ASSERT(odp_packet_align(&pkt, 0, pkt_len, 0) < 0); >>> >>> offset = seg_len - 5; >>> - pkt_data = odp_packet_offset(pkt, offset, &seg_len, NULL); >>> + (void)odp_packet_offset(pkt, offset, &seg_len, NULL); >>> >>> /* Realign for addressability */ >>> CU_ASSERT(odp_packet_align(&pkt, offset, >>> @@ -1167,8 +1167,7 @@ void packet_test_align(void) >>> >>> /* Alignment doesn't change packet length or contents */ >>> CU_ASSERT(odp_packet_len(pkt) == pkt_len); >>> - aligned_data = odp_packet_offset(pkt, offset, >>> - &aligned_seglen, NULL); >>> + (void)odp_packet_offset(pkt, offset, &aligned_seglen, >>> NULL); >>> _packet_compare_offset(pkt, offset, >>> segmented_test_packet, offset, >>> aligned_seglen); >>> -- >>> 2.7.4 >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> https://lists.linaro.org/mailman/listinfo/lng-odp >>> >> >> >> -- >> Mike Holmes >> Technical Manager - Linaro Networking Group >> Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs >> "Work should be fun and collaborative, the rest follows" >> >> >> > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/test/validation/packet/packet.c b/test/validation/packet/packet.c index 7c9622f..bf8d9f4 100644 --- a/test/validation/packet/packet.c +++ b/test/validation/packet/packet.c @@ -1159,7 +1159,7 @@ void packet_test_align(void) CU_ASSERT(odp_packet_align(&pkt, 0, pkt_len, 0) < 0); offset = seg_len - 5; - pkt_data = odp_packet_offset(pkt, offset, &seg_len, NULL); + (void)odp_packet_offset(pkt, offset, &seg_len, NULL); /* Realign for addressability */ CU_ASSERT(odp_packet_align(&pkt, offset, @@ -1167,8 +1167,7 @@ void packet_test_align(void) /* Alignment doesn't change packet length or contents */ CU_ASSERT(odp_packet_len(pkt) == pkt_len); - aligned_data = odp_packet_offset(pkt, offset, - &aligned_seglen, NULL); + (void)odp_packet_offset(pkt, offset, &aligned_seglen, NULL); _packet_compare_offset(pkt, offset, segmented_test_packet, offset, aligned_seglen);
Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2220 by removing unused values. Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> --- test/validation/packet/packet.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)