| Message ID | 20230510-feature-ts_virtobj_patch-v1-4-5ae5e81bc264@wolfvision.net |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Input: support virtual objects on touchscreens | expand |
On Wed, 10 May 2023 15:50:49 +0200, Javier Carrasco wrote: > The st1232 driver supports the virtual-touchscreen and virtual-buttons > objects defined in the generic touchscreen bindings and implemented in > the ts-virtobj module. Add an example where nodes for a virtual > touchscreen and virtual buttons are defined. > > Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> > --- > .../input/touchscreen/sitronix,st1232.yaml | 40 ++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.example.dtb: touchscreen@55: Unevaluated properties are not allowed ('virtual-buttons', 'virtual-touchscreen' were unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml See https://patchwork.ozlabs.org/patch/1779521 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 10.05.23 16:59, Krzysztof Kozlowski wrote: > On Wed, 10 May 2023 15:50:49 +0200, Javier Carrasco wrote: >> The st1232 driver supports the virtual-touchscreen and virtual-buttons >> objects defined in the generic touchscreen bindings and implemented in >> the ts-virtobj module. Add an example where nodes for a virtual >> touchscreen and virtual buttons are defined. >> >> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> >> --- >> .../input/touchscreen/sitronix,st1232.yaml | 40 ++++++++++++++++++++++ >> 1 file changed, 40 insertions(+) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.example.dtb: touchscreen@55: Unevaluated properties are not allowed ('virtual-buttons', 'virtual-touchscreen' were unexpected) > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml > Thanks for your feedback. This patch depends on: 'PATCH 2/4: dt-bindings: touchscreen: add virtual-touchscreen and virtual-buttons properties' from the same series, where 'virtual-buttons' and 'virtual-touchscreen' are defined in 'touchscreen.yaml'. I could only reproduce the error after reverting the patch it depends on. Otherwise it passes the tests successfully and with no warning reports with dt-schema 04.2023 and yamllint 1.31.0 > See https://patchwork.ozlabs.org/patch/1779521 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml b/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml index 1d8ca19fd37a..97a2c063b47c 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml @@ -48,3 +48,43 @@ examples: gpios = <&gpio1 166 0>; }; }; + - | + #include <dt-bindings/input/linux-event-codes.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + touchscreen@55 { + compatible = "sitronix,st1232"; + reg = <0x55>; + interrupts = <2 0>; + gpios = <&gpio1 166 0>; + + virtual-touchscreen { + x-origin = <0>; + x-size = <240>; + y-origin = <40>; + y-size = <280>; + }; + + virtual-buttons { + button-light { + label = "Camera light"; + linux,code = <KEY_LIGHTS_TOGGLE>; + x-origin = <40>; + x-size = <40>; + y-origin = <0>; + y-size = <40>; + }; + + button-suspend { + label = "Suspend"; + linux,code = <KEY_SUSPEND>; + x-origin = <160>; + x-size = <40>; + y-origin = <0>; + y-size = <40>; + }; + }; + }; + };
The st1232 driver supports the virtual-touchscreen and virtual-buttons objects defined in the generic touchscreen bindings and implemented in the ts-virtobj module. Add an example where nodes for a virtual touchscreen and virtual buttons are defined. Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> --- .../input/touchscreen/sitronix,st1232.yaml | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+)