| Message ID | 1463501549-12191-1-git-send-email-rizwan.ansari@linaro.org |
|---|---|
| State | Accepted |
| Commit | 1b1da0fe917cb916232fd9aad615b68941b8f490 |
| Headers | show |
Bala, please review Octeon specific change. Maxim. On 05/17/16 19:12, Rizwan Ansari wrote: > Removes odp_sync_stores() call for OCTEON, Octeon > build will fail, As this api has been already > replaced by odp_mb_full(). > > Signed-off-by: Rizwan Ansari <rizwan.ansari@linaro.org> > Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> > --- > platform/linux-generic/odp_ticketlock.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/platform/linux-generic/odp_ticketlock.c b/platform/linux-generic/odp_ticketlock.c > index 7b4246f..353af9a 100644 > --- a/platform/linux-generic/odp_ticketlock.c > +++ b/platform/linux-generic/odp_ticketlock.c > @@ -69,9 +69,6 @@ void odp_ticketlock_unlock(odp_ticketlock_t *ticketlock) > > odp_atomic_store_rel_u32(&ticketlock->cur_ticket, cur + 1); > > -#if defined __OCTEON__ > - odp_sync_stores(); /* SYNCW to flush write buffer */ > -#endif > } > > int odp_ticketlock_is_locked(odp_ticketlock_t *ticketlock)
Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> Regards, Bala On 17 May 2016 at 21:42, Rizwan Ansari <rizwan.ansari@linaro.org> wrote: > Removes odp_sync_stores() call for OCTEON, Octeon > build will fail, As this api has been already > replaced by odp_mb_full(). > > Signed-off-by: Rizwan Ansari <rizwan.ansari@linaro.org> > Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> > --- > platform/linux-generic/odp_ticketlock.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/platform/linux-generic/odp_ticketlock.c b/platform/linux-generic/odp_ticketlock.c > index 7b4246f..353af9a 100644 > --- a/platform/linux-generic/odp_ticketlock.c > +++ b/platform/linux-generic/odp_ticketlock.c > @@ -69,9 +69,6 @@ void odp_ticketlock_unlock(odp_ticketlock_t *ticketlock) > > odp_atomic_store_rel_u32(&ticketlock->cur_ticket, cur + 1); > > -#if defined __OCTEON__ > - odp_sync_stores(); /* SYNCW to flush write buffer */ > -#endif > } > > int odp_ticketlock_is_locked(odp_ticketlock_t *ticketlock) > -- > 2.5.5 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
Merged, Maxim. On 06/30/16 15:42, Bala Manoharan wrote: > Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> > > Regards, > Bala > > > On 17 May 2016 at 21:42, Rizwan Ansari <rizwan.ansari@linaro.org> wrote: >> Removes odp_sync_stores() call for OCTEON, Octeon >> build will fail, As this api has been already >> replaced by odp_mb_full(). >> >> Signed-off-by: Rizwan Ansari <rizwan.ansari@linaro.org> >> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> >> --- >> platform/linux-generic/odp_ticketlock.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/platform/linux-generic/odp_ticketlock.c b/platform/linux-generic/odp_ticketlock.c >> index 7b4246f..353af9a 100644 >> --- a/platform/linux-generic/odp_ticketlock.c >> +++ b/platform/linux-generic/odp_ticketlock.c >> @@ -69,9 +69,6 @@ void odp_ticketlock_unlock(odp_ticketlock_t *ticketlock) >> >> odp_atomic_store_rel_u32(&ticketlock->cur_ticket, cur + 1); >> >> -#if defined __OCTEON__ >> - odp_sync_stores(); /* SYNCW to flush write buffer */ >> -#endif >> } >> >> int odp_ticketlock_is_locked(odp_ticketlock_t *ticketlock) >> -- >> 2.5.5 >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/platform/linux-generic/odp_ticketlock.c b/platform/linux-generic/odp_ticketlock.c index 7b4246f..353af9a 100644 --- a/platform/linux-generic/odp_ticketlock.c +++ b/platform/linux-generic/odp_ticketlock.c @@ -69,9 +69,6 @@ void odp_ticketlock_unlock(odp_ticketlock_t *ticketlock) odp_atomic_store_rel_u32(&ticketlock->cur_ticket, cur + 1); -#if defined __OCTEON__ - odp_sync_stores(); /* SYNCW to flush write buffer */ -#endif } int odp_ticketlock_is_locked(odp_ticketlock_t *ticketlock)