| Message ID | 20230428121524.2125832-2-valentin.caron@foss.st.com |
|---|---|
| State | New |
| Headers | show |
| Series | spi: stm32: add spi slave mode | expand |
On Fri, Apr 28, 2023 at 02:15:18PM +0200, Valentin Caron wrote: > Theses properties need to be described to satisfy dtbs_check. No, they are defined in spi-controller.yaml, so they should not be needed here. > > Signed-off-by: Valentin Caron <valentin.caron@foss.st.com> > --- > Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml > index 9ca1a843c820..c599eb359d56 100644 > --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml > +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml > @@ -29,6 +29,9 @@ allOf: > st,spi-midi-ns: false > > properties: > + "#address-cells": true > + "#size-cells": true > + > compatible: > enum: > - st,stm32f4-spi > -- > 2.25.1 >
Hi Rob, On 4/28/23 23:41, Rob Herring wrote: > On Fri, Apr 28, 2023 at 02:15:18PM +0200, Valentin Caron wrote: >> Theses properties need to be described to satisfy dtbs_check. > No, they are defined in spi-controller.yaml, so they should not be > needed here. Yes, you're right, I cannot remember why I need to add theses properties. Thank you, Valentin >> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com> >> --- >> Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml >> index 9ca1a843c820..c599eb359d56 100644 >> --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml >> +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml >> @@ -29,6 +29,9 @@ allOf: >> st,spi-midi-ns: false >> >> properties: >> + "#address-cells": true >> + "#size-cells": true >> + >> compatible: >> enum: >> - st,stm32f4-spi >> -- >> 2.25.1 >>
diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml index 9ca1a843c820..c599eb359d56 100644 --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml @@ -29,6 +29,9 @@ allOf: st,spi-midi-ns: false properties: + "#address-cells": true + "#size-cells": true + compatible: enum: - st,stm32f4-spi
Theses properties need to be described to satisfy dtbs_check. Signed-off-by: Valentin Caron <valentin.caron@foss.st.com> --- Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 3 +++ 1 file changed, 3 insertions(+)