mbox

[PULL,00/18] testing and doc updates

Message ID 20230427154510.1791273-1-alex.bennee@linaro.org
State New
Headers show

Pull-request

https://gitlab.com/stsquad/qemu.git tags/pull-testing-docs-270423-1

Message

Alex Bennée April 27, 2023, 3:44 p.m. UTC
The following changes since commit 1eb95e1baef852d0971a1dd62a3293cd68f1ec35:

  Merge tag 'migration-20230426-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-04-27 10:47:14 +0100)

are available in the Git repository at:

  https://gitlab.com/stsquad/qemu.git tags/pull-testing-docs-270423-1

for you to fetch changes up to ef46ae67ba9a785cf0cce58b5fc5a36ed3c6c7b9:

  docs/style: call out the use of GUARD macros (2023-04-27 14:58:51 +0100)

----------------------------------------------------------------
Testing and documentation updates:

  - bump avocado to 101.0
  - use snapshots for tuxrun baseline tests
  - add sbda-ref test to avocado
  - avoid spurious re-configure in gitlab
  - better description of blockdev options
  - drop FreeBSD 12 from Cirrus CI
  - fix up the ast2[56]00 tests to be more stable
  - improve coverage of ppc64 tests in tuxrun baselines
  - limit plugin tests to just the generic multiarch binaries

----------------------------------------------------------------
Alex Bennée (7):
      tests/avocado: use the new snapshots for testing
      qemu-options: finesse the recommendations around -blockdev
      tests/tcg: limit the scope of the plugin tests
      docs/system: remove excessive punctuation from guest-loader docs
      docs/devel: make a statement about includes
      docs/devel: mention the spacing requirement for QOM
      docs/style: call out the use of GUARD macros

Kautuk Consul (3):
      tests/requirements.txt: bump up avocado-framework version to 101.0
      avocado_qemu/__init__.py: factor out the qemu-img finding
      tests/avocado/tuxrun_baselines.py: improve code coverage for ppc64

Philippe Mathieu-Daudé (1):
      tests/avocado: Add set of boot tests on SBSA-ref

Thomas Huth (6):
      gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs
      scripts/device-crash-test: Add a parameter to run with TCG only
      .gitlab-ci.d/cirrus: Drop the CI job for compiling with FreeBSD 12
      tests/avocado: Make ssh_command_output_contains() globally available
      tests/avocado/machine_aspeed: Fix the broken ast2[56]00_evb_sdk tests
      MAINTAINERS: Cover tests/avocado/machine_aspeed.py

Yohei Kojima (1):
      qemu-options.hx: Update descriptions of memory options for NUMA node

 MAINTAINERS                               |   3 +-
 docs/devel/qom.rst                        |   2 +
 docs/devel/style.rst                      | 105 ++++++++++++++
 docs/system/guest-loader.rst              |   6 +-
 .gitlab-ci.d/buildtest.yml                |   6 +-
 .gitlab-ci.d/cirrus.yml                   |  13 --
 .gitlab-ci.d/cirrus/freebsd-12.vars       |  16 ---
 qemu-options.hx                           |  49 +++++--
 scripts/device-crash-test                 |   4 +-
 tests/Makefile.include                    |  18 ++-
 tests/avocado/avocado_qemu/__init__.py    |  35 +++--
 tests/avocado/linux_ssh_mips_malta.py     |   8 --
 tests/avocado/machine_aarch64_sbsaref.py  | 158 ++++++++++++++++++++
 tests/avocado/machine_aspeed.py           |  30 ++--
 tests/avocado/tuxrun_baselines.py         | 232 ++++++++++++++++++++++++++----
 tests/lcitool/refresh                     |   1 -
 tests/requirements.txt                    |   2 +-
 tests/tcg/Makefile.target                 |  10 +-
 tests/tcg/aarch64/Makefile.softmmu-target |   2 -
 tests/tcg/aarch64/Makefile.target         |   1 -
 tests/tcg/arm/Makefile.softmmu-target     |   4 +-
 tests/tcg/arm/Makefile.target             |   8 --
 tests/tcg/cris/Makefile.target            |   3 +
 tests/tcg/hppa/Makefile.target            |   2 -
 tests/tcg/i386/Makefile.target            |  10 --
 tests/tcg/ppc64/Makefile.target           |   2 -
 tests/tcg/riscv64/Makefile.softmmu-target |   3 +
 tests/tcg/riscv64/Makefile.target         |   1 -
 tests/tcg/s390x/Makefile.softmmu-target   |   3 +
 tests/tcg/tricore/Makefile.softmmu-target |   3 +
 tests/tcg/xtensa/Makefile.softmmu-target  |   3 +
 31 files changed, 596 insertions(+), 147 deletions(-)
 delete mode 100644 .gitlab-ci.d/cirrus/freebsd-12.vars
 create mode 100644 tests/avocado/machine_aarch64_sbsaref.py

Comments

Richard Henderson April 28, 2023, 7:34 a.m. UTC | #1
On 4/27/23 16:44, Alex Bennée wrote:
> The following changes since commit 1eb95e1baef852d0971a1dd62a3293cd68f1ec35:
> 
>    Merge tag 'migration-20230426-pull-request' ofhttps://gitlab.com/juan.quintela/qemu  into staging (2023-04-27 10:47:14 +0100)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/stsquad/qemu.git  tags/pull-testing-docs-270423-1
> 
> for you to fetch changes up to ef46ae67ba9a785cf0cce58b5fc5a36ed3c6c7b9:
> 
>    docs/style: call out the use of GUARD macros (2023-04-27 14:58:51 +0100)
> 
> ----------------------------------------------------------------
> Testing and documentation updates:
> 
>    - bump avocado to 101.0
>    - use snapshots for tuxrun baseline tests
>    - add sbda-ref test to avocado
>    - avoid spurious re-configure in gitlab
>    - better description of blockdev options
>    - drop FreeBSD 12 from Cirrus CI
>    - fix up the ast2[56]00 tests to be more stable
>    - improve coverage of ppc64 tests in tuxrun baselines
>    - limit plugin tests to just the generic multiarch binaries

Applied, thanks.  Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate.


r~
Peter Maydell May 2, 2023, 11:46 a.m. UTC | #2
On Thu, 27 Apr 2023 at 16:47, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> The following changes since commit 1eb95e1baef852d0971a1dd62a3293cd68f1ec35:
>
>   Merge tag 'migration-20230426-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-04-27 10:47:14 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/stsquad/qemu.git tags/pull-testing-docs-270423-1
>
> for you to fetch changes up to ef46ae67ba9a785cf0cce58b5fc5a36ed3c6c7b9:
>
>   docs/style: call out the use of GUARD macros (2023-04-27 14:58:51 +0100)
>
> ----------------------------------------------------------------
> Testing and documentation updates:
>
>   - bump avocado to 101.0

Did this change the behaviour of 'make check-avocado' ?
Previously it would continue the whole test run even if one
test timed out; now it seems to abort the test run when the
first test times out.

I don't object to the current behaviour, but is there some
command line option I can use to force avocado to complete
the whole test set even if there are failures or timeouts?

('make check-avocado' for arm targets has some persistent
intermittent timeout stuff still, so I generally prefer to
eyeball the failures and ignore the stuff I know is flaky.)

thanks
-- PMM
Thomas Huth May 2, 2023, 12:21 p.m. UTC | #3
On 02/05/2023 13.46, Peter Maydell wrote:
> On Thu, 27 Apr 2023 at 16:47, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> The following changes since commit 1eb95e1baef852d0971a1dd62a3293cd68f1ec35:
>>
>>    Merge tag 'migration-20230426-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-04-27 10:47:14 +0100)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/stsquad/qemu.git tags/pull-testing-docs-270423-1
>>
>> for you to fetch changes up to ef46ae67ba9a785cf0cce58b5fc5a36ed3c6c7b9:
>>
>>    docs/style: call out the use of GUARD macros (2023-04-27 14:58:51 +0100)
>>
>> ----------------------------------------------------------------
>> Testing and documentation updates:
>>
>>    - bump avocado to 101.0
> 
> Did this change the behaviour of 'make check-avocado' ?
> Previously it would continue the whole test run even if one
> test timed out; now it seems to abort the test run when the
> first test times out.
> 
> I don't object to the current behaviour, but is there some
> command line option I can use to force avocado to complete
> the whole test set even if there are failures or timeouts?
> 
> ('make check-avocado' for arm targets has some persistent
> intermittent timeout stuff still, so I generally prefer to
> eyeball the failures and ignore the stuff I know is flaky.)

I think I've seen it in the past, too:

 
https://lore.kernel.org/qemu-devel/7836af42-9969-a01a-3c8c-717987b0b27e@redhat.com/

... but after Cleber said that there is no change in behavior, I did not 
follow up. Anyway, it is likely related to that --failfast switch of 
Avocado, so that's likely the first thing to look for, I guess...

  Thomas