| Message ID | 20230424182559.92271-1-dnojiri@chromium.org |
|---|---|
| State | Accepted |
| Commit | b2f2a3c9800208b0db2c2e34b05323757117faa2 |
| Headers | show |
| Series | power: supply: sbs: Fix INHIBITED bit for Status reg | expand |
Hi, On Mon, Apr 24, 2023 at 11:25:58AM -0700, Daisuke Nojiri wrote: > CHARGE_INHIBITED bit position of the ChargerStatus register is actually > 0 not 1. This patch corrects it. > > Change-Id: I08630b264eddd09b94c8f6d299724c39218e958a > Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> > --- Thanks, queued to power-supply's fixes branch with Change-Id line replaced by Fixes: feb583e37f8a8 ("power: supply: add sbs-charger driver") -- Sebastian > drivers/power/supply/sbs-charger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/sbs-charger.c b/drivers/power/supply/sbs-charger.c > index 75ebcbf0a788..a14e89ac0369 100644 > --- a/drivers/power/supply/sbs-charger.c > +++ b/drivers/power/supply/sbs-charger.c > @@ -24,7 +24,7 @@ > #define SBS_CHARGER_REG_STATUS 0x13 > #define SBS_CHARGER_REG_ALARM_WARNING 0x16 > > -#define SBS_CHARGER_STATUS_CHARGE_INHIBITED BIT(1) > +#define SBS_CHARGER_STATUS_CHARGE_INHIBITED BIT(0) > #define SBS_CHARGER_STATUS_RES_COLD BIT(9) > #define SBS_CHARGER_STATUS_RES_HOT BIT(10) > #define SBS_CHARGER_STATUS_BATTERY_PRESENT BIT(14) > -- > 2.40.0.634.g4ca3ef3211-goog >
diff --git a/drivers/power/supply/sbs-charger.c b/drivers/power/supply/sbs-charger.c index 75ebcbf0a788..a14e89ac0369 100644 --- a/drivers/power/supply/sbs-charger.c +++ b/drivers/power/supply/sbs-charger.c @@ -24,7 +24,7 @@ #define SBS_CHARGER_REG_STATUS 0x13 #define SBS_CHARGER_REG_ALARM_WARNING 0x16 -#define SBS_CHARGER_STATUS_CHARGE_INHIBITED BIT(1) +#define SBS_CHARGER_STATUS_CHARGE_INHIBITED BIT(0) #define SBS_CHARGER_STATUS_RES_COLD BIT(9) #define SBS_CHARGER_STATUS_RES_HOT BIT(10) #define SBS_CHARGER_STATUS_BATTERY_PRESENT BIT(14)
CHARGE_INHIBITED bit position of the ChargerStatus register is actually 0 not 1. This patch corrects it. Change-Id: I08630b264eddd09b94c8f6d299724c39218e958a Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> --- drivers/power/supply/sbs-charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)