| Message ID | 20230424054105.1579315-55-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tcg: Simplify calls to load/store helpers | expand |
On 24/4/23 07:41, Richard Henderson wrote: > These constraints have not been used for quite some time. > > Fixes: 77b73de67632 ("Use rem/div[u]_i32 drop div[u]2_i32") > Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > tcg/ppc/tcg-target-con-str.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/tcg/ppc/tcg-target-con-str.h b/tcg/ppc/tcg-target-con-str.h > index f3bf030bc3..9dcbc3df50 100644 > --- a/tcg/ppc/tcg-target-con-str.h > +++ b/tcg/ppc/tcg-target-con-str.h > @@ -10,10 +10,6 @@ > */ > REGS('r', ALL_GENERAL_REGS) > REGS('v', ALL_VECTOR_REGS) > -REGS('A', 1u << TCG_REG_R3) > -REGS('B', 1u << TCG_REG_R4) > -REGS('C', 1u << TCG_REG_R5) > -REGS('D', 1u << TCG_REG_R6) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Is the J constraint introduced in commit 3d582c6179 ("tcg-ppc64: Rearrange integer constant constraints") ever used?
On 4/29/23 13:29, Philippe Mathieu-Daudé wrote: > On 24/4/23 07:41, Richard Henderson wrote: >> These constraints have not been used for quite some time. >> >> Fixes: 77b73de67632 ("Use rem/div[u]_i32 drop div[u]2_i32") >> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com> >> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> >> --- >> tcg/ppc/tcg-target-con-str.h | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/tcg/ppc/tcg-target-con-str.h b/tcg/ppc/tcg-target-con-str.h >> index f3bf030bc3..9dcbc3df50 100644 >> --- a/tcg/ppc/tcg-target-con-str.h >> +++ b/tcg/ppc/tcg-target-con-str.h >> @@ -10,10 +10,6 @@ >> */ >> REGS('r', ALL_GENERAL_REGS) >> REGS('v', ALL_VECTOR_REGS) >> -REGS('A', 1u << TCG_REG_R3) >> -REGS('B', 1u << TCG_REG_R4) >> -REGS('C', 1u << TCG_REG_R5) >> -REGS('D', 1u << TCG_REG_R6) > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > > Is the J constraint introduced in commit 3d582c6179 > ("tcg-ppc64: Rearrange integer constant constraints") > ever used? Nope, not anymore. Used to be for and/or/xor, now replaced by more general constraints. Will remove. r~
diff --git a/tcg/ppc/tcg-target-con-str.h b/tcg/ppc/tcg-target-con-str.h index f3bf030bc3..9dcbc3df50 100644 --- a/tcg/ppc/tcg-target-con-str.h +++ b/tcg/ppc/tcg-target-con-str.h @@ -10,10 +10,6 @@ */ REGS('r', ALL_GENERAL_REGS) REGS('v', ALL_VECTOR_REGS) -REGS('A', 1u << TCG_REG_R3) -REGS('B', 1u << TCG_REG_R4) -REGS('C', 1u << TCG_REG_R5) -REGS('D', 1u << TCG_REG_R6) /* * Define constraint letters for constants:
These constraints have not been used for quite some time. Fixes: 77b73de67632 ("Use rem/div[u]_i32 drop div[u]2_i32") Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- tcg/ppc/tcg-target-con-str.h | 4 ---- 1 file changed, 4 deletions(-)