diff mbox series

arm64: dts: nuvoton: add missing cache properties

Message ID 20230421223154.115312-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit a8cf500c42c751b992f5480c390d6ad2419472e0
Headers show
Series arm64: dts: nuvoton: add missing cache properties | expand

Commit Message

Krzysztof Kozlowski April 21, 2023, 10:31 p.m. UTC
As all level 2 and level 3 caches are unified, add required
cache-unified and cache-level properties to fix warnings like:

  nuvoton-npcm845-evb.dtb: l2-cache: 'cache-level' is a required property
  nuvoton-npcm845-evb.dtb: l2-cache: 'cache-unified' is a required property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Please take the patch via sub-arch SoC tree.
---
 arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski May 16, 2023, 4:30 p.m. UTC | #1
On 22/04/2023 00:31, Krzysztof Kozlowski wrote:
> As all level 2 and level 3 caches are unified, add required
> cache-unified and cache-level properties to fix warnings like:
> 
>   nuvoton-npcm845-evb.dtb: l2-cache: 'cache-level' is a required property
>   nuvoton-npcm845-evb.dtb: l2-cache: 'cache-unified' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Please take the patch via sub-arch SoC tree.
> ---

Hi Tomer, Tali, Patrick and others,

Anyone picking this up?

Best regards,
Krzysztof
Tomer Maimon June 1, 2023, 9:22 a.m. UTC | #2
Hi Krzysztof,

Sorry for the late reply and thanks for your patch.

On Tue, 16 May 2023 at 19:30, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 22/04/2023 00:31, Krzysztof Kozlowski wrote:
> > As all level 2 and level 3 caches are unified, add required
> > cache-unified and cache-level properties to fix warnings like:
> >
> >   nuvoton-npcm845-evb.dtb: l2-cache: 'cache-level' is a required property
> >   nuvoton-npcm845-evb.dtb: l2-cache: 'cache-unified' is a required property
I didn't get these warnings in kernel 6.4-rc4, but still, the patch
has been tested on EVB-NPCM8XX and everything looks good.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > ---
> >
> > Please take the patch via sub-arch SoC tree.
> > ---
>
> Hi Tomer, Tali, Patrick and others,
>
> Anyone picking this up?
>
> Best regards,
> Krzysztof
>
Reviewed-by: Tomer Maimon <tmaimon77@gmail.com>

Best regards,

Tomer
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi
index 12118b75c0e6..383938dcd3ce 100644
--- a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi
+++ b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845.dtsi
@@ -49,6 +49,8 @@  cpu3: cpu@3 {
 
 		l2: l2-cache {
 			compatible = "cache";
+			cache-level = <2>;
+			cache-unified;
 		};
 	};