diff mbox series

[1/4] ARM: dts: s5pv210: align pin configuration nodes with bindings

Message ID 20230421095721.31857-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit 7e98d368887c08a6cb79e79684f851e9bd9a3550
Headers show
Series [1/4] ARM: dts: s5pv210: align pin configuration nodes with bindings | expand

Commit Message

Krzysztof Kozlowski April 21, 2023, 9:57 a.m. UTC
Bindings expect that pins in initial and sleep states nodes end with
'-pin':

  s5pv210-fascinate4g.dtb: pinctrl@e0200000: sleep-state: 'gpa0-0', ...
    'mp07-7' do not match any of the regexes: '^(pin-[a-z0-9-]+|[a-z0-9-]+-pin)$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/s5pv210-pinctrl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski May 8, 2023, 5:04 p.m. UTC | #1
On Fri, 21 Apr 2023 11:57:18 +0200, Krzysztof Kozlowski wrote:
> Bindings expect that pins in initial and sleep states nodes end with
> '-pin':
> 
>   s5pv210-fascinate4g.dtb: pinctrl@e0200000: sleep-state: 'gpa0-0', ...
>     'mp07-7' do not match any of the regexes: '^(pin-[a-z0-9-]+|[a-z0-9-]+-pin)$', 'pinctrl-[0-9]+'
> 
> 
> [...]

Applied, thanks!

[1/4] ARM: dts: s5pv210: align pin configuration nodes with bindings
      https://git.kernel.org/krzk/linux/c/7e98d368887c08a6cb79e79684f851e9bd9a3550
[2/4] ARM: dts: s5pv210: align USB node name with bindings
      https://git.kernel.org/krzk/linux/c/64f92c24aa57f8bfc389fe6638f0ffb7e4605928
[3/4] ARM: dts: s5pv210: re-order MFC clock names to match Exynos and bindings
      https://git.kernel.org/krzk/linux/c/6175f658ae07804f7c347903b8c6781e0914d3e6
[4/4] ARM: dts: s5pv210: add dummy 5V regulator for backlight on SMDKv210
      https://git.kernel.org/krzk/linux/c/b77904ba177a9c67b6dbc3637fdf1faa22df6e5c

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/s5pv210-pinctrl.dtsi b/arch/arm/boot/dts/s5pv210-pinctrl.dtsi
index 6d6daef9fb7a..ae0b4a423746 100644
--- a/arch/arm/boot/dts/s5pv210-pinctrl.dtsi
+++ b/arch/arm/boot/dts/s5pv210-pinctrl.dtsi
@@ -19,7 +19,7 @@ 
 #include "s5pv210-pinctrl.h"
 
 #define PIN_SLP(_pin, _mode, _pull)					\
-	_pin {								\
+	pin- ## _pin {							\
 		samsung,pins = #_pin;					\
 		samsung,pin-con-pdn = <S5PV210_PIN_PDN_ ##_mode>;	\
 		samsung,pin-pud-pdn = <S5PV210_PIN_PULL_ ##_pull>;	\