| Message ID | 20230420222558.1208887-2-dmitry.baryshkov@linaro.org |
|---|---|
| State | Accepted |
| Commit | 10036161efbf573fa5b2e42463e5bffe6f9bfb6d |
| Headers | show |
| Series | [v2,1/2] drm/msm/dpu: drop the regdma configuration | expand |
On 2023-04-21 01:25:58, Dmitry Baryshkov wrote: > Stop mapping the regdma region. The driver does not support regdma. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Should you add a third patch to remove this from dt-bindings? (msm8998 has it in both dpu and mdss files) Regardless, the patch itself is: Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 ------ > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 +- > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index 0e7a68714e9e..28d74d4d2c1d 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -1033,12 +1033,6 @@ static int dpu_kms_hw_init(struct msm_kms *kms) > DPU_DEBUG("VBIF NRT is not defined"); > } > > - dpu_kms->reg_dma = msm_ioremap_quiet(dpu_kms->pdev, "regdma"); > - if (IS_ERR(dpu_kms->reg_dma)) { > - dpu_kms->reg_dma = NULL; > - DPU_DEBUG("REG_DMA is not defined"); > - } > - > dpu_kms_parse_data_bus_icc_path(dpu_kms); > > rc = pm_runtime_resume_and_get(&dpu_kms->pdev->dev); > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > index aca39a4689f4..15111e433f21 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > @@ -71,7 +71,7 @@ struct dpu_kms { > const struct dpu_mdss_cfg *catalog; > > /* io/register spaces: */ > - void __iomem *mmio, *vbif[VBIF_MAX], *reg_dma; > + void __iomem *mmio, *vbif[VBIF_MAX]; > > struct regulator *vdd; > struct regulator *mmagic; > -- > 2.39.2 >
On 4/20/2023 3:25 PM, Dmitry Baryshkov wrote: > Stop mapping the regdma region. The driver does not support regdma. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- As pointed out by Marijn, the binding can be dropped too but for this change, Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index 0e7a68714e9e..28d74d4d2c1d 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -1033,12 +1033,6 @@ static int dpu_kms_hw_init(struct msm_kms *kms) DPU_DEBUG("VBIF NRT is not defined"); } - dpu_kms->reg_dma = msm_ioremap_quiet(dpu_kms->pdev, "regdma"); - if (IS_ERR(dpu_kms->reg_dma)) { - dpu_kms->reg_dma = NULL; - DPU_DEBUG("REG_DMA is not defined"); - } - dpu_kms_parse_data_bus_icc_path(dpu_kms); rc = pm_runtime_resume_and_get(&dpu_kms->pdev->dev); diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h index aca39a4689f4..15111e433f21 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h @@ -71,7 +71,7 @@ struct dpu_kms { const struct dpu_mdss_cfg *catalog; /* io/register spaces: */ - void __iomem *mmio, *vbif[VBIF_MAX], *reg_dma; + void __iomem *mmio, *vbif[VBIF_MAX]; struct regulator *vdd; struct regulator *mmagic;
Stop mapping the regdma region. The driver does not support regdma. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 ------ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-)