| Message ID | 20230413194020.1077857-3-ahalaney@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/3] arm64: dts: qcom: sa8155p-adp: Make compatible the first property | expand |
On 13.04.2023 21:40, Andrew Halaney wrote: > Using interrupts-extended already indicates what the interrupt-parent > is, so drop the explicit interrupt-parent. > > The comment about this being the phy-intr is not helpful either, since > this is the only interrupt in the phy node. > > Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > Changes since v1: > * New patch (Konrad) > > arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > index ac52a8dfeba1..b65e0203d783 100644 > --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > @@ -361,8 +361,7 @@ rgmii_phy: phy@7 { > compatible = "ethernet-phy-ieee802.3-c22"; > reg = <0x7>; > > - interrupt-parent = <&tlmm>; > - interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ > + interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; > device_type = "ethernet-phy"; > }; > };
diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index ac52a8dfeba1..b65e0203d783 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -361,8 +361,7 @@ rgmii_phy: phy@7 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; - interrupt-parent = <&tlmm>; - interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ + interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; device_type = "ethernet-phy"; }; };
Using interrupts-extended already indicates what the interrupt-parent is, so drop the explicit interrupt-parent. The comment about this being the phy-intr is not helpful either, since this is the only interrupt in the phy node. Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- Changes since v1: * New patch (Konrad) arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)