| Message ID | 20230412053824.106-5-ychuang570808@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce Nuvoton ma35d1 SoC | expand |
On 12/04/2023 07:38, Jacky Huang wrote: > From: Jacky Huang <ychuang3@nuvoton.com> > > Add the dt-bindings header for Nuvoton ma35d1, that gets shared > between the reset controller and reset references in the dts. > Add documentation to describe nuvoton ma35d1 reset driver. > > Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> This is an automated instruction, just in case, because many review tags are being ignored. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 Best regards, Krzysztof
Quoting Jacky Huang (2023-04-11 22:38:16) > diff --git a/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml > new file mode 100644 > index 000000000000..3ce7dcecd87a > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/nuvoton,ma35d1-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton MA35D1 Reset Controller > + > +maintainers: > + - Chi-Fang Li <cfli0@nuvoton.com> > + - Jacky Huang <ychuang3@nuvoton.com> > + > +description: > + The system reset controller can be used to reset various peripheral > + controllers in MA35D1 SoC. > + > +properties: > + compatible: > + items: > + - const: nuvoton,ma35d1-reset > + - const: syscon Does it need to be a syscon anymore?
Dear Krzysztof, On 2023/4/14 上午 12:58, Krzysztof Kozlowski wrote: > On 12/04/2023 07:38, Jacky Huang wrote: >> From: Jacky Huang <ychuang3@nuvoton.com> >> >> Add the dt-bindings header for Nuvoton ma35d1, that gets shared >> between the reset controller and reset references in the dts. >> Add documentation to describe nuvoton ma35d1 reset driver. >> >> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > This is an automated instruction, just in case, because many review tags > are being ignored. If you do not know the process, here is a short > explanation: > > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tools like b4 can help > here. However, there's no need to repost patches *only* to add the tags. > The upstream maintainer will do that for acks received on the version > they apply. > > https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 > > Best regards, > Krzysztof > Thank you for your explanation. I was not aware of the rules for adding tags, and it was my mistake. I thought that it was necessary for the reviewer to proactively add the "reviewed-by" tag to the patch before I could attach the tag. I am glad to collect the past records and add the tags and will update in the next version. Best regards, Jacky Huang
Dear Stephen, On 2023/4/14 上午 04:21, Stephen Boyd wrote: > Quoting Jacky Huang (2023-04-11 22:38:16) >> diff --git a/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml >> new file mode 100644 >> index 000000000000..3ce7dcecd87a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml >> @@ -0,0 +1,46 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/reset/nuvoton,ma35d1-reset.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Nuvoton MA35D1 Reset Controller >> + >> +maintainers: >> + - Chi-Fang Li <cfli0@nuvoton.com> >> + - Jacky Huang <ychuang3@nuvoton.com> >> + >> +description: >> + The system reset controller can be used to reset various peripheral >> + controllers in MA35D1 SoC. >> + >> +properties: >> + compatible: >> + items: >> + - const: nuvoton,ma35d1-reset >> + - const: syscon > Does it need to be a syscon anymore? Yes, it should be removed. I will fix it in the next version. Best regards, YC
On 14/04/2023 02:55, Jacky Huang wrote: > Dear Krzysztof, > > > On 2023/4/14 上午 12:58, Krzysztof Kozlowski wrote: >> On 12/04/2023 07:38, Jacky Huang wrote: >>> From: Jacky Huang <ychuang3@nuvoton.com> >>> >>> Add the dt-bindings header for Nuvoton ma35d1, that gets shared >>> between the reset controller and reset references in the dts. >>> Add documentation to describe nuvoton ma35d1 reset driver. >>> >>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> >> This is an automated instruction, just in case, because many review tags >> are being ignored. If you do not know the process, here is a short >> explanation: >> >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions, under or above your Signed-off-by tag. Tools like b4 can help >> here. However, there's no need to repost patches *only* to add the tags. >> The upstream maintainer will do that for acks received on the version >> they apply. >> >> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 >> >> Best regards, >> Krzysztof >> > > Thank you for your explanation. I was not aware of the rules for adding > tags, and it was my mistake. > I thought that it was necessary for the reviewer to proactively add the > "reviewed-by" tag to the patch I proactively added the tag last time. You expect me to review it every time and every time add my tag? You know, we all have better things to do... Best regards, Krzysztof
On 2023/4/14 下午 03:46, Krzysztof Kozlowski wrote: > On 14/04/2023 02:55, Jacky Huang wrote: >> Dear Krzysztof, >> >> >> On 2023/4/14 上午 12:58, Krzysztof Kozlowski wrote: >>> On 12/04/2023 07:38, Jacky Huang wrote: >>>> From: Jacky Huang <ychuang3@nuvoton.com> >>>> >>>> Add the dt-bindings header for Nuvoton ma35d1, that gets shared >>>> between the reset controller and reset references in the dts. >>>> Add documentation to describe nuvoton ma35d1 reset driver. >>>> >>>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> >>> This is an automated instruction, just in case, because many review tags >>> are being ignored. If you do not know the process, here is a short >>> explanation: >>> >>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >>> versions, under or above your Signed-off-by tag. Tools like b4 can help >>> here. However, there's no need to repost patches *only* to add the tags. >>> The upstream maintainer will do that for acks received on the version >>> they apply. >>> >>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 >>> >>> Best regards, >>> Krzysztof >>> >> Thank you for your explanation. I was not aware of the rules for adding >> tags, and it was my mistake. >> I thought that it was necessary for the reviewer to proactively add the >> "reviewed-by" tag to the patch > I proactively added the tag last time. You expect me to review it every > time and every time add my tag? You know, we all have better things to do... > > Best regards, > Krzysztof > Dear Krzysztof, Got it, I will make sure to add review tags for this patch in all subsequent versions. Of course, other patches that have received review tags should also be included. Best regards, Jacky Huang
diff --git a/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml new file mode 100644 index 000000000000..3ce7dcecd87a --- /dev/null +++ b/Documentation/devicetree/bindings/reset/nuvoton,ma35d1-reset.yaml @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/reset/nuvoton,ma35d1-reset.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton MA35D1 Reset Controller + +maintainers: + - Chi-Fang Li <cfli0@nuvoton.com> + - Jacky Huang <ychuang3@nuvoton.com> + +description: + The system reset controller can be used to reset various peripheral + controllers in MA35D1 SoC. + +properties: + compatible: + items: + - const: nuvoton,ma35d1-reset + - const: syscon + + reg: + maxItems: 1 + + '#reset-cells': + const: 1 + +required: + - compatible + - reg + - '#reset-cells' + +additionalProperties: false + +examples: + # system reset controller node: + - | + + system-management@40460000 { + compatible = "nuvoton,ma35d1-reset", "syscon"; + reg = <0x40460000 0x200>; + #reset-cells = <1>; + }; +... + diff --git a/include/dt-bindings/reset/nuvoton,ma35d1-reset.h b/include/dt-bindings/reset/nuvoton,ma35d1-reset.h new file mode 100644 index 000000000000..44c01e66d06c --- /dev/null +++ b/include/dt-bindings/reset/nuvoton,ma35d1-reset.h @@ -0,0 +1,108 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (C) 2023 Nuvoton Technologies. + * Author: Chi-Fen Li <cfli0@nuvoton.com> + * + * Device Tree binding constants for MA35D1 reset controller. + */ + +#ifndef __DT_BINDINGS_RESET_MA35D1_H +#define __DT_BINDINGS_RESET_MA35D1_H + +#define MA35D1_RESET_CHIP 0 +#define MA35D1_RESET_CA35CR0 1 +#define MA35D1_RESET_CA35CR1 2 +#define MA35D1_RESET_CM4 3 +#define MA35D1_RESET_PDMA0 4 +#define MA35D1_RESET_PDMA1 5 +#define MA35D1_RESET_PDMA2 6 +#define MA35D1_RESET_PDMA3 7 +#define MA35D1_RESET_DISP 8 +#define MA35D1_RESET_VCAP0 9 +#define MA35D1_RESET_VCAP1 10 +#define MA35D1_RESET_GFX 11 +#define MA35D1_RESET_VDEC 12 +#define MA35D1_RESET_WHC0 13 +#define MA35D1_RESET_WHC1 14 +#define MA35D1_RESET_GMAC0 15 +#define MA35D1_RESET_GMAC1 16 +#define MA35D1_RESET_HWSEM 17 +#define MA35D1_RESET_EBI 18 +#define MA35D1_RESET_HSUSBH0 19 +#define MA35D1_RESET_HSUSBH1 20 +#define MA35D1_RESET_HSUSBD 21 +#define MA35D1_RESET_USBHL 22 +#define MA35D1_RESET_SDH0 23 +#define MA35D1_RESET_SDH1 24 +#define MA35D1_RESET_NAND 25 +#define MA35D1_RESET_GPIO 26 +#define MA35D1_RESET_MCTLP 27 +#define MA35D1_RESET_MCTLC 28 +#define MA35D1_RESET_DDRPUB 29 +#define MA35D1_RESET_TMR0 30 +#define MA35D1_RESET_TMR1 31 +#define MA35D1_RESET_TMR2 32 +#define MA35D1_RESET_TMR3 33 +#define MA35D1_RESET_I2C0 34 +#define MA35D1_RESET_I2C1 35 +#define MA35D1_RESET_I2C2 36 +#define MA35D1_RESET_I2C3 37 +#define MA35D1_RESET_QSPI0 38 +#define MA35D1_RESET_SPI0 39 +#define MA35D1_RESET_SPI1 40 +#define MA35D1_RESET_SPI2 41 +#define MA35D1_RESET_UART0 42 +#define MA35D1_RESET_UART1 43 +#define MA35D1_RESET_UART2 44 +#define MA35D1_RESET_UAER3 45 +#define MA35D1_RESET_UART4 46 +#define MA35D1_RESET_UART5 47 +#define MA35D1_RESET_UART6 48 +#define MA35D1_RESET_UART7 49 +#define MA35D1_RESET_CANFD0 50 +#define MA35D1_RESET_CANFD1 51 +#define MA35D1_RESET_EADC0 52 +#define MA35D1_RESET_I2S0 53 +#define MA35D1_RESET_SC0 54 +#define MA35D1_RESET_SC1 55 +#define MA35D1_RESET_QSPI1 56 +#define MA35D1_RESET_SPI3 57 +#define MA35D1_RESET_EPWM0 58 +#define MA35D1_RESET_EPWM1 59 +#define MA35D1_RESET_QEI0 60 +#define MA35D1_RESET_QEI1 61 +#define MA35D1_RESET_ECAP0 62 +#define MA35D1_RESET_ECAP1 63 +#define MA35D1_RESET_CANFD2 64 +#define MA35D1_RESET_ADC0 65 +#define MA35D1_RESET_TMR4 66 +#define MA35D1_RESET_TMR5 67 +#define MA35D1_RESET_TMR6 68 +#define MA35D1_RESET_TMR7 69 +#define MA35D1_RESET_TMR8 70 +#define MA35D1_RESET_TMR9 71 +#define MA35D1_RESET_TMR10 72 +#define MA35D1_RESET_TMR11 73 +#define MA35D1_RESET_UART8 74 +#define MA35D1_RESET_UART9 75 +#define MA35D1_RESET_UART10 76 +#define MA35D1_RESET_UART11 77 +#define MA35D1_RESET_UART12 78 +#define MA35D1_RESET_UART13 79 +#define MA35D1_RESET_UART14 80 +#define MA35D1_RESET_UART15 81 +#define MA35D1_RESET_UART16 82 +#define MA35D1_RESET_I2S1 83 +#define MA35D1_RESET_I2C4 84 +#define MA35D1_RESET_I2C5 85 +#define MA35D1_RESET_EPWM2 86 +#define MA35D1_RESET_ECAP2 87 +#define MA35D1_RESET_QEI2 88 +#define MA35D1_RESET_CANFD3 89 +#define MA35D1_RESET_KPI 90 +#define MA35D1_RESET_GIC 91 +#define MA35D1_RESET_SSMCC 92 +#define MA35D1_RESET_SSPCC 93 +#define MA35D1_RESET_COUNT 94 + +#endif