| Message ID | 20230410181005.25853-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable" | expand |
On 10.04.2023 20:10, Krzysztof Kozlowski wrote: > Pin configuration property "input-enable" was used with the intention to > disable the output, but this is done by default by Linux drivers. Since > patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not > input-enable") the property is not accepted anymore. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts | 2 -- > arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts | 1 - > arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 3 --- > 3 files changed, 6 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts > index 7a80e1c9f126..aa0e0e8d2a97 100644 > --- a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts > +++ b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts > @@ -268,7 +268,6 @@ bluetooth_default_state: bluetooth-default-state { > function = "gpio"; > drive-strength = <8>; > bias-disable; > - input-enable; > }; > > wlan_hostwake_default_state: wlan-hostwake-default-state { > @@ -276,7 +275,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state { > function = "gpio"; > drive-strength = <2>; > bias-disable; > - input-enable; > }; > > wlan_regulator_default_state: wlan-regulator-default-state { > diff --git a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts > index d64096028ab1..5593a3a60d6c 100644 > --- a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts > +++ b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts > @@ -352,7 +352,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state { > function = "gpio"; > drive-strength = <2>; > bias-disable; > - input-enable; > }; > > wlan_regulator_default_state: wlan-regulator-default-state { > diff --git a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts > index b82381229adf..b887e5361ec3 100644 > --- a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts > +++ b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts > @@ -307,7 +307,6 @@ bluetooth_default_state: bluetooth-default-state { > function = "gpio"; > drive-strength = <2>; > bias-disable; > - input-enable; > }; > > touch_pins: touch-state { > @@ -317,7 +316,6 @@ irq-pins { > > drive-strength = <8>; > bias-pull-down; > - input-enable; > }; > > reset-pins { > @@ -335,7 +333,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state { > function = "gpio"; > drive-strength = <2>; > bias-disable; > - input-enable; > }; > > wlan_regulator_default_state: wlan-regulator-default-state {
On 10.04.2023 20:10, Krzysztof Kozlowski wrote: > Pin configuration property "input-enable" was used with the intention to > disable the output, but this is done by default by Linux drivers. Since > patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not > input-enable") the property is not accepted anymore. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > index a8304769b509..b269fdca1460 100644 > --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > @@ -49,7 +49,6 @@ gpioext1_pins: gpioext1-state { > gpioext1-pins { > pins = "gpio2"; > function = "gpio"; > - input-enable; > bias-disable; > }; > };
On Mon, 10 Apr 2023 20:10:03 +0200, Krzysztof Kozlowski wrote: > Pin configuration property "input-enable" was used with the intention to > disable the output, but this is done by default by Linux drivers. Since > patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not > input-enable") the property is not accepted anymore. > > Applied, thanks! [1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable" commit: 18f341061262a7a63bc8b5c9ef94a342ac2673a2 [2/3] ARM: dts: qcom: mdm9615: remove superfluous "input-enable" commit: da50416fb1fa7502a52ad38c0e9ff196d9f56ac9 [3/3] ARM: dts: qcom: msm8974: remove superfluous "input-enable" commit: 033553c04b02b450261f60d5f1b0e5948cd197bb Best regards,
diff --git a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts index 7a80e1c9f126..aa0e0e8d2a97 100644 --- a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts +++ b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts @@ -268,7 +268,6 @@ bluetooth_default_state: bluetooth-default-state { function = "gpio"; drive-strength = <8>; bias-disable; - input-enable; }; wlan_hostwake_default_state: wlan-hostwake-default-state { @@ -276,7 +275,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state { function = "gpio"; drive-strength = <2>; bias-disable; - input-enable; }; wlan_regulator_default_state: wlan-regulator-default-state { diff --git a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts index d64096028ab1..5593a3a60d6c 100644 --- a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts +++ b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts @@ -352,7 +352,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state { function = "gpio"; drive-strength = <2>; bias-disable; - input-enable; }; wlan_regulator_default_state: wlan-regulator-default-state { diff --git a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts index b82381229adf..b887e5361ec3 100644 --- a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts +++ b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts @@ -307,7 +307,6 @@ bluetooth_default_state: bluetooth-default-state { function = "gpio"; drive-strength = <2>; bias-disable; - input-enable; }; touch_pins: touch-state { @@ -317,7 +316,6 @@ irq-pins { drive-strength = <8>; bias-pull-down; - input-enable; }; reset-pins { @@ -335,7 +333,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state { function = "gpio"; drive-strength = <2>; bias-disable; - input-enable; }; wlan_regulator_default_state: wlan-regulator-default-state {
Pin configuration property "input-enable" was used with the intention to disable the output, but this is done by default by Linux drivers. Since patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not input-enable") the property is not accepted anymore. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts | 2 -- arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts | 1 - arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 3 --- 3 files changed, 6 deletions(-)