diff mbox series

arm64: dts: qcom: pm8998: don't use GIC_SPI for SPMI interrupts

Message ID 20230409182145.122895-1-dmitry.baryshkov@linaro.org
State Accepted
Commit d9ef7a805a709a0b07341857d97a25598a7f92da
Headers show
Series arm64: dts: qcom: pm8998: don't use GIC_SPI for SPMI interrupts | expand

Commit Message

Dmitry Baryshkov April 9, 2023, 6:21 p.m. UTC
Unlike typical GIC interrupts, first cell for SPMI interrupts is the
USID rather than GIC_SPI/GIC_PPI/GIC_LPI qualifier. Fix the resin
interrupt to use USID value 0x0 rather than GIC_SPI define.

Fixes: f86ae6f23a9e ("arm64: dts: qcom: sagit: add initial device tree for sagit")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Dybcio April 11, 2023, 10:59 a.m. UTC | #1
On 9.04.2023 20:21, Dmitry Baryshkov wrote:
> Unlike typical GIC interrupts, first cell for SPMI interrupts is the
> USID rather than GIC_SPI/GIC_PPI/GIC_LPI qualifier. Fix the resin
> interrupt to use USID value 0x0 rather than GIC_SPI define.
> 
> Fixes: f86ae6f23a9e ("arm64: dts: qcom: sagit: add initial device tree for sagit")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> index adbba9f4089a..13925ac44669 100644
> --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> @@ -55,7 +55,7 @@ pm8998_pwrkey: pwrkey {
>  
>  			pm8998_resin: resin {
>  				compatible = "qcom,pm8941-resin";
> -				interrupts = <GIC_SPI 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> +				interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
>  				debounce = <15625>;
>  				bias-pull-up;
>  				status = "disabled";
Bjorn Andersson May 25, 2023, 4:53 a.m. UTC | #2
On Sun, 9 Apr 2023 21:21:45 +0300, Dmitry Baryshkov wrote:
> Unlike typical GIC interrupts, first cell for SPMI interrupts is the
> USID rather than GIC_SPI/GIC_PPI/GIC_LPI qualifier. Fix the resin
> interrupt to use USID value 0x0 rather than GIC_SPI define.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: pm8998: don't use GIC_SPI for SPMI interrupts
      commit: d9ef7a805a709a0b07341857d97a25598a7f92da

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index adbba9f4089a..13925ac44669 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -55,7 +55,7 @@  pm8998_pwrkey: pwrkey {
 
 			pm8998_resin: resin {
 				compatible = "qcom,pm8941-resin";
-				interrupts = <GIC_SPI 0x8 1 IRQ_TYPE_EDGE_BOTH>;
+				interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
 				debounce = <15625>;
 				bias-pull-up;
 				status = "disabled";