diff mbox series

[v6,06/12] dt-bindings: arm: Add initial bindings for Nuvoton platform

Message ID 20230328021912.177301-7-ychuang570808@gmail.com
State New
Headers show
Series Introduce Nuvoton ma35d1 SoC | expand

Commit Message

Jacky Huang March 28, 2023, 2:19 a.m. UTC
From: Jacky Huang <ychuang3@nuvoton.com>

Rename the bindings/arm/npcm directory as nuvoton.
Add binding for ARMv8 based Nuvotn SoCs and platform boards.
Add initial bindings for ma35d1 series development boards.

Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
---
 .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml  | 30 +++++++++++++++++++
 .../nuvoton,npcm-gcr.yaml}                    |  2 +-
 .../npcm.yaml => nuvoton/nuvoton,npcm.yaml}   |  2 +-
 3 files changed, 32 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml
 rename Documentation/devicetree/bindings/arm/{npcm/nuvoton,gcr.yaml => nuvoton/nuvoton,npcm-gcr.yaml} (93%)
 rename Documentation/devicetree/bindings/arm/{npcm/npcm.yaml => nuvoton/nuvoton,npcm.yaml} (93%)

Comments

Jacky Huang March 30, 2023, 10:41 a.m. UTC | #1
Dear Rob,


On 2023/3/29 下午 09:07, Rob Herring wrote:
> On Mon, Mar 27, 2023 at 9:19 PM Jacky Huang <ychuang570808@gmail.com> wrote:
>> From: Jacky Huang <ychuang3@nuvoton.com>
>>
>> Rename the bindings/arm/npcm directory as nuvoton.
>> Add binding for ARMv8 based Nuvotn SoCs and platform boards.
>> Add initial bindings for ma35d1 series development boards.
>>
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>> ---
>>   .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml  | 30 +++++++++++++++++++
>>   .../nuvoton,npcm-gcr.yaml}                    |  2 +-
>>   .../npcm.yaml => nuvoton/nuvoton,npcm.yaml}   |  2 +-
>>   3 files changed, 32 insertions(+), 2 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml
>>   rename Documentation/devicetree/bindings/arm/{npcm/nuvoton,gcr.yaml => nuvoton/nuvoton,npcm-gcr.yaml} (93%)
> Since you are moving it, this one should be moved to bindings/soc/nuvoton/
>
>>   rename Documentation/devicetree/bindings/arm/{npcm/npcm.yaml => nuvoton/nuvoton,npcm.yaml} (93%)

OK, I will move "Documentation/devicetree/bindings/arm/npcm" to
"Documentation/devicetree/bindings/soc/nuvoton".


Best regards,
Jacky Huang
Jacky Huang March 31, 2023, 2:15 a.m. UTC | #2
On 2023/3/30 下午 09:25, Krzysztof Kozlowski wrote:
> On 30/03/2023 12:41, Jacky Huang wrote:
>> Dear Rob,
>>
>>
>> On 2023/3/29 下午 09:07, Rob Herring wrote:
>>> On Mon, Mar 27, 2023 at 9:19 PM Jacky Huang <ychuang570808@gmail.com> wrote:
>>>> From: Jacky Huang <ychuang3@nuvoton.com>
>>>>
>>>> Rename the bindings/arm/npcm directory as nuvoton.
>>>> Add binding for ARMv8 based Nuvotn SoCs and platform boards.
>>>> Add initial bindings for ma35d1 series development boards.
>>>>
>>>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>>>> ---
>>>>    .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml  | 30 +++++++++++++++++++
>>>>    .../nuvoton,npcm-gcr.yaml}                    |  2 +-
>>>>    .../npcm.yaml => nuvoton/nuvoton,npcm.yaml}   |  2 +-
>>>>    3 files changed, 32 insertions(+), 2 deletions(-)
>>>>    create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml
>>>>    rename Documentation/devicetree/bindings/arm/{npcm/nuvoton,gcr.yaml => nuvoton/nuvoton,npcm-gcr.yaml} (93%)
>>> Since you are moving it, this one should be moved to bindings/soc/nuvoton/
>>>
>>>>    rename Documentation/devicetree/bindings/arm/{npcm/npcm.yaml => nuvoton/nuvoton,npcm.yaml} (93%)
>> OK, I will move "Documentation/devicetree/bindings/arm/npcm" to
>> "Documentation/devicetree/bindings/soc/nuvoton".
> To clarify - Rob asked *this one*. Not all.
>
>
>
> Best regards,
> Krzysztof
>

Dear Krzysztof,

I am sorry that still cannot get it exactly.

1. Just only submit  the nuvoton,ma35d1.yaml to
Documentation/devicetree/bindings/soc/nuvoton/nuvoton,ma35d1.yaml
     and keep Documentation/devicetree/bindings/arm/npcm unchanged

2. Move the directory "Documentation/devicetree/bindings/arm/npcm" to 
"Documentation/devicetree/bindings/soc/nuvoton"
    and submit  the nuvoton,ma35d1.yaml to 
"Documentation/devicetree/bindings/soc/nuvoton"

I should do 1 or 2?  Thank you very much.


Best regards,
Jacky Huang
Rob Herring (Arm) April 3, 2023, 8:33 p.m. UTC | #3
On Fri, Mar 31, 2023 at 10:15:16AM +0800, Jacky Huang wrote:
> 
> 
> On 2023/3/30 下午 09:25, Krzysztof Kozlowski wrote:
> > On 30/03/2023 12:41, Jacky Huang wrote:
> > > Dear Rob,
> > > 
> > > 
> > > On 2023/3/29 下午 09:07, Rob Herring wrote:
> > > > On Mon, Mar 27, 2023 at 9:19 PM Jacky Huang <ychuang570808@gmail.com> wrote:
> > > > > From: Jacky Huang <ychuang3@nuvoton.com>
> > > > > 
> > > > > Rename the bindings/arm/npcm directory as nuvoton.
> > > > > Add binding for ARMv8 based Nuvotn SoCs and platform boards.
> > > > > Add initial bindings for ma35d1 series development boards.
> > > > > 
> > > > > Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> > > > > ---
> > > > >    .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml  | 30 +++++++++++++++++++
> > > > >    .../nuvoton,npcm-gcr.yaml}                    |  2 +-
> > > > >    .../npcm.yaml => nuvoton/nuvoton,npcm.yaml}   |  2 +-
> > > > >    3 files changed, 32 insertions(+), 2 deletions(-)
> > > > >    create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml
> > > > >    rename Documentation/devicetree/bindings/arm/{npcm/nuvoton,gcr.yaml => nuvoton/nuvoton,npcm-gcr.yaml} (93%)
> > > > Since you are moving it, this one should be moved to bindings/soc/nuvoton/
> > > > 
> > > > >    rename Documentation/devicetree/bindings/arm/{npcm/npcm.yaml => nuvoton/nuvoton,npcm.yaml} (93%)
> > > OK, I will move "Documentation/devicetree/bindings/arm/npcm" to
> > > "Documentation/devicetree/bindings/soc/nuvoton".
> > To clarify - Rob asked *this one*. Not all.

nuvoton,gcr.yaml is what should be moved to bindings/soc/... The rest 
are the correct locations.

> > 
> > 
> > 
> > Best regards,
> > Krzysztof
> > 
> 
> Dear Krzysztof,
> 
> I am sorry that still cannot get it exactly.
> 
> 1. Just only submit  the nuvoton,ma35d1.yaml to
> Documentation/devicetree/bindings/soc/nuvoton/nuvoton,ma35d1.yaml
>     and keep Documentation/devicetree/bindings/arm/npcm unchanged
> 
> 2. Move the directory "Documentation/devicetree/bindings/arm/npcm" to
> "Documentation/devicetree/bindings/soc/nuvoton"
>    and submit  the nuvoton,ma35d1.yaml to
> "Documentation/devicetree/bindings/soc/nuvoton"
> 
> I should do 1 or 2?  Thank you very much.

Neither.

Arm board and soc root node bindings go in bindings/arm/...

Miscellaneous system registers that don't fit into any other bindings/* 
subsystem directory go in bindings/soc/

Rob
Jacky Huang April 6, 2023, 2:09 a.m. UTC | #4
On 2023/4/4 上午 04:33, Rob Herring wrote:
> On Fri, Mar 31, 2023 at 10:15:16AM +0800, Jacky Huang wrote:
>>
>> On 2023/3/30 下午 09:25, Krzysztof Kozlowski wrote:
>>> On 30/03/2023 12:41, Jacky Huang wrote:
>>>> Dear Rob,
>>>>
>>>>
>>>> On 2023/3/29 下午 09:07, Rob Herring wrote:
>>>>> On Mon, Mar 27, 2023 at 9:19 PM Jacky Huang <ychuang570808@gmail.com> wrote:
>>>>>> From: Jacky Huang <ychuang3@nuvoton.com>
>>>>>>
>>>>>> Rename the bindings/arm/npcm directory as nuvoton.
>>>>>> Add binding for ARMv8 based Nuvotn SoCs and platform boards.
>>>>>> Add initial bindings for ma35d1 series development boards.
>>>>>>
>>>>>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>>>>>> ---
>>>>>>     .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml  | 30 +++++++++++++++++++
>>>>>>     .../nuvoton,npcm-gcr.yaml}                    |  2 +-
>>>>>>     .../npcm.yaml => nuvoton/nuvoton,npcm.yaml}   |  2 +-
>>>>>>     3 files changed, 32 insertions(+), 2 deletions(-)
>>>>>>     create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml
>>>>>>     rename Documentation/devicetree/bindings/arm/{npcm/nuvoton,gcr.yaml => nuvoton/nuvoton,npcm-gcr.yaml} (93%)
>>>>> Since you are moving it, this one should be moved to bindings/soc/nuvoton/
>>>>>
>>>>>>     rename Documentation/devicetree/bindings/arm/{npcm/npcm.yaml => nuvoton/nuvoton,npcm.yaml} (93%)
>>>> OK, I will move "Documentation/devicetree/bindings/arm/npcm" to
>>>> "Documentation/devicetree/bindings/soc/nuvoton".
>>> To clarify - Rob asked *this one*. Not all.
> nuvoton,gcr.yaml is what should be moved to bindings/soc/... The rest
> are the correct locations.
>
>>>
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> Dear Krzysztof,
>>
>> I am sorry that still cannot get it exactly.
>>
>> 1. Just only submit  the nuvoton,ma35d1.yaml to
>> Documentation/devicetree/bindings/soc/nuvoton/nuvoton,ma35d1.yaml
>>      and keep Documentation/devicetree/bindings/arm/npcm unchanged
>>
>> 2. Move the directory "Documentation/devicetree/bindings/arm/npcm" to
>> "Documentation/devicetree/bindings/soc/nuvoton"
>>     and submit  the nuvoton,ma35d1.yaml to
>> "Documentation/devicetree/bindings/soc/nuvoton"
>>
>> I should do 1 or 2?  Thank you very much.
> Neither.
>
> Arm board and soc root node bindings go in bindings/arm/...
>
> Miscellaneous system registers that don't fit into any other bindings/*
> subsystem directory go in bindings/soc/
>
> Rob

Dear Rob,

Thank you very much. I got it now.


Best regards,
Jacky Huang
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml b/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml
new file mode 100644
index 000000000000..fb190db61525
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml
@@ -0,0 +1,30 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/nuvoton/nuvoton,ma35d1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Nuvoton MA35 series SoC based platforms
+
+maintainers:
+  - Jacky Huang <ychuang3@nuvoton.com>
+
+description: |
+  Boards with an ARMv8 based Nuvoton MA35 series SoC shall have
+  the following properties.
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+
+      - description: MA35D1 based boards
+        items:
+          - enum:
+              - nuvoton,ma35d1-iot
+              - nuvoton,ma35d1-som
+          - const: nuvoton,ma35d1
+
+additionalProperties: true
+...
diff --git a/Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml b/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,npcm-gcr.yaml
similarity index 93%
rename from Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml
rename to Documentation/devicetree/bindings/arm/nuvoton/nuvoton,npcm-gcr.yaml
index 94e72f25b331..1f354aa900ea 100644
--- a/Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml
+++ b/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,npcm-gcr.yaml
@@ -1,7 +1,7 @@ 
 # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/arm/npcm/nuvoton,gcr.yaml#
+$id: http://devicetree.org/schemas/arm/nuvoton/nuvoton,npcm-gcr.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Global Control Registers block in Nuvoton SoCs
diff --git a/Documentation/devicetree/bindings/arm/npcm/npcm.yaml b/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,npcm.yaml
similarity index 93%
rename from Documentation/devicetree/bindings/arm/npcm/npcm.yaml
rename to Documentation/devicetree/bindings/arm/nuvoton/nuvoton,npcm.yaml
index 6871483947c5..d386744c8815 100644
--- a/Documentation/devicetree/bindings/arm/npcm/npcm.yaml
+++ b/Documentation/devicetree/bindings/arm/nuvoton/nuvoton,npcm.yaml
@@ -1,7 +1,7 @@ 
 # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/arm/npcm/npcm.yaml#
+$id: http://devicetree.org/schemas/arm/nuvoton/nuvoton,npcm.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: NPCM Platforms