| Message ID | 1461788445-13596-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | Accepted |
| Commit | 7bea2a27840cb88658472f4734d17eaaf4cbd93c |
| Headers | show |
How come your v2 just shows the diff compared to v1? and not the complete patch again? Has the first patch been merged already? (looks like your v2 has to be applied in v1) other than that, for the patch contents, you can apply my reviewed by on the fix (Reviewed-by: Christophe Milard <christophe.milard@linaro.org> ): Christophe. On 27 April 2016 at 22:20, Mike Holmes <mike.holmes@linaro.org> wrote: > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > v2 > codespell does not check the spelling of checkpatch :) > > > DEPENDENCIES | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/DEPENDENCIES b/DEPENDENCIES > index c83fc36..f8e18e2 100644 > --- a/DEPENDENCIES > +++ b/DEPENDENCIES > @@ -253,3 +253,10 @@ The tested version of doxygen is 1.8.8 > 5.2.1 HTML > # Debian/Ubuntu > $ apt-get install asciidoc source-highlight librsvg2-bin > + > +6.0 Submitting patches > + > + When submitting patches they should be checked with ./scripts/ > checkpatch.pl > + To have this tool also check spelling you need codespell. > + # Debian/Ubuntu > + #sudo apt install codespell > -- > 2.7.4 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
Got cheated by google mail! this is fine! Reviewed-by: Christophe Milard <christophe.milard@linaro.org> On 28 April 2016 at 07:52, Christophe Milard <christophe.milard@linaro.org> wrote: > How come your v2 just shows the diff compared to v1? and not the complete > patch again? > > Has the first patch been merged already? (looks like your v2 has to be > applied in v1) > > other than that, for the patch contents, you can apply my reviewed by on > the fix (Reviewed-by: Christophe Milard <christophe.milard@linaro.org> ): > > Christophe. > > On 27 April 2016 at 22:20, Mike Holmes <mike.holmes@linaro.org> wrote: > >> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >> --- >> v2 >> codespell does not check the spelling of checkpatch :) >> >> >> DEPENDENCIES | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/DEPENDENCIES b/DEPENDENCIES >> index c83fc36..f8e18e2 100644 >> --- a/DEPENDENCIES >> +++ b/DEPENDENCIES >> @@ -253,3 +253,10 @@ The tested version of doxygen is 1.8.8 >> 5.2.1 HTML >> # Debian/Ubuntu >> $ apt-get install asciidoc source-highlight librsvg2-bin >> + >> +6.0 Submitting patches >> + >> + When submitting patches they should be checked with ./scripts/ >> checkpatch.pl >> + To have this tool also check spelling you need codespell. >> + # Debian/Ubuntu >> + #sudo apt install codespell >> -- >> 2.7.4 >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > >
that was merged, Maxim. On 04/28/16 11:17, Christophe Milard wrote: > Got cheated by google mail! this is fine! > Reviewed-by: Christophe Milard <christophe.milard@linaro.org > <mailto:christophe.milard@linaro.org>> > > On 28 April 2016 at 07:52, Christophe Milard > <christophe.milard@linaro.org <mailto:christophe.milard@linaro.org>> > wrote: > > How come your v2 just shows the diff compared to v1? and not the > complete patch again? > > Has the first patch been merged already? (looks like your v2 has > to be applied in v1) > > other than that, for the patch contents, you can apply my reviewed > by on the fix (Reviewed-by: Christophe Milard > <christophe.milard@linaro.org > <mailto:christophe.milard@linaro.org>> ): > > Christophe. > > On 27 April 2016 at 22:20, Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> wrote: > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> > --- > v2 > codespell does not check the spelling of checkpatch :) > > > DEPENDENCIES | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/DEPENDENCIES b/DEPENDENCIES > index c83fc36..f8e18e2 100644 > --- a/DEPENDENCIES > +++ b/DEPENDENCIES > @@ -253,3 +253,10 @@ The tested version of doxygen is 1.8.8 > 5.2.1 HTML > # Debian/Ubuntu > $ apt-get install asciidoc source-highlight librsvg2-bin > + > +6.0 Submitting patches > + > + When submitting patches they should be checked with > ./scripts/checkpatch.pl <http://checkpatch.pl> > + To have this tool also check spelling you need codespell. > + # Debian/Ubuntu > + #sudo apt install codespell > -- > 2.7.4 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/DEPENDENCIES b/DEPENDENCIES index c83fc36..f8e18e2 100644 --- a/DEPENDENCIES +++ b/DEPENDENCIES @@ -253,3 +253,10 @@ The tested version of doxygen is 1.8.8 5.2.1 HTML # Debian/Ubuntu $ apt-get install asciidoc source-highlight librsvg2-bin + +6.0 Submitting patches + + When submitting patches they should be checked with ./scripts/checkpatch.pl + To have this tool also check spelling you need codespell. + # Debian/Ubuntu + #sudo apt install codespell
Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- v2 codespell does not check the spelling of checkpatch :) DEPENDENCIES | 7 +++++++ 1 file changed, 7 insertions(+)