| Message ID | 20230324004040.572525-1-konrad.dybcio@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/7] mmc: msm_sdhci: Match clocks through "clocks" property | expand |
Hi, On Fri, 24 Mar 2023 at 07:26, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > "clocks" is the standard property used in Linux, "clock" seems to be > an U-Boot invention. Use the one that's more standardized. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > > drivers/mmc/msm_sdhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/msm_sdhci.c b/drivers/mmc/msm_sdhci.c > index 604f9c3ff99c..174435f01f68 100644 > --- a/drivers/mmc/msm_sdhci.c > +++ b/drivers/mmc/msm_sdhci.c > @@ -63,7 +63,7 @@ static int msm_sdc_clk_init(struct udevice *dev) > struct clk clk; > int ret; > > - ret = fdtdec_get_int_array(gd->fdt_blob, node, "clock", clkd, 2); > + ret = fdtdec_get_int_array(gd->fdt_blob, node, "clocks", clkd, 2); You have to update corresponding dts files as well to avoid breaking platforms. -Sumit > if (ret) > return ret; > > -- > 2.40.0 >
Hi Konrad, On Fri, 24 Mar 2023 at 06:10, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > "clocks" is the standard property used in Linux, "clock" seems to be > an U-Boot invention. Use the one that's more standardized. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > > drivers/mmc/msm_sdhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/msm_sdhci.c b/drivers/mmc/msm_sdhci.c > index 604f9c3ff99c..174435f01f68 100644 > --- a/drivers/mmc/msm_sdhci.c > +++ b/drivers/mmc/msm_sdhci.c > @@ -63,7 +63,7 @@ static int msm_sdc_clk_init(struct udevice *dev) > struct clk clk; > int ret; > > - ret = fdtdec_get_int_array(gd->fdt_blob, node, "clock", clkd, 2); > + ret = fdtdec_get_int_array(gd->fdt_blob, node, "clocks", clkd, 2); > if (ret) > return ret; This would break existing msm platforms like qcs404 and rb3. So, please send the changed dts for those platforms with the driver changes. We would also need to test the changes on those platforms first. Same is valid for other driver patches which alter the dts properties without changing the actual dtsi/dts first. Thanks, Bhupesh
diff --git a/drivers/mmc/msm_sdhci.c b/drivers/mmc/msm_sdhci.c index 604f9c3ff99c..174435f01f68 100644 --- a/drivers/mmc/msm_sdhci.c +++ b/drivers/mmc/msm_sdhci.c @@ -63,7 +63,7 @@ static int msm_sdc_clk_init(struct udevice *dev) struct clk clk; int ret; - ret = fdtdec_get_int_array(gd->fdt_blob, node, "clock", clkd, 2); + ret = fdtdec_get_int_array(gd->fdt_blob, node, "clocks", clkd, 2); if (ret) return ret;
"clocks" is the standard property used in Linux, "clock" seems to be an U-Boot invention. Use the one that's more standardized. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- drivers/mmc/msm_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)