diff mbox series

ALSA: hdspm: remove unused copy_u32_le function

Message ID 20230323202713.2637150-1-trix@redhat.com
State Accepted
Commit 2c7598903f18418aa18d11a9dd081acb22e9e108
Headers show
Series ALSA: hdspm: remove unused copy_u32_le function | expand

Commit Message

Tom Rix March 23, 2023, 8:27 p.m. UTC
clang with W=1 reports
sound/pci/rme9652/hdspm.c:6149:19: error: unused function
  'copy_u32_le' [-Werror,-Wunused-function]
static inline int copy_u32_le(void __user *dest, void __iomem *src)
                  ^
This function is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 sound/pci/rme9652/hdspm.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Takashi Iwai March 24, 2023, 6:51 a.m. UTC | #1
On Thu, 23 Mar 2023 21:27:13 +0100,
Tom Rix wrote:
> 
> clang with W=1 reports
> sound/pci/rme9652/hdspm.c:6149:19: error: unused function
>   'copy_u32_le' [-Werror,-Wunused-function]
> static inline int copy_u32_le(void __user *dest, void __iomem *src)
>                   ^
> This function is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Applied to for-next branch.  Thanks.


Takashi
diff mbox series

Patch

diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
index fa1812e7a49d..267c7848974a 100644
--- a/sound/pci/rme9652/hdspm.c
+++ b/sound/pci/rme9652/hdspm.c
@@ -6146,12 +6146,6 @@  static int snd_hdspm_hwdep_dummy_op(struct snd_hwdep *hw, struct file *file)
 	return 0;
 }
 
-static inline int copy_u32_le(void __user *dest, void __iomem *src)
-{
-	u32 val = readl(src);
-	return copy_to_user(dest, &val, 4);
-}
-
 static int snd_hdspm_hwdep_ioctl(struct snd_hwdep *hw, struct file *file,
 		unsigned int cmd, unsigned long arg)
 {