| Message ID | 20230318121828.739424-3-bryan.odonoghue@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Qualcomm PMIC TPCM support | expand |
On 18/03/2023 13:18, Bryan O'Donoghue wrote: > The VBUS driver needs to know the regulator-min-microamp and > regulator-max-microamp so they should both be marked as required. > > regulator.yaml defines those two dependencies so include regulator.yaml. > > We need to change from additionalProperties: false to > unevaluatedProperties: false. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 18/03/2023 13:18, Bryan O'Donoghue wrote: > The VBUS driver needs to know the regulator-min-microamp and > regulator-max-microamp so they should both be marked as required. > > regulator.yaml defines those two dependencies so include regulator.yaml. > > We need to change from additionalProperties: false to > unevaluatedProperties: false. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../bindings/regulator/qcom,usb-vbus-regulator.yaml | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml > index 7a3b59f836092..f6ecb0f72ad9a 100644 > --- a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml > @@ -14,6 +14,9 @@ description: | > regulator will be enabled in situations where the device is required to > provide power to the connected peripheral. > > +allOf: > + - $ref: "regulator.yaml#" Drop quotes. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml index 7a3b59f836092..f6ecb0f72ad9a 100644 --- a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml @@ -14,6 +14,9 @@ description: | regulator will be enabled in situations where the device is required to provide power to the connected peripheral. +allOf: + - $ref: "regulator.yaml#" + properties: compatible: enum: @@ -26,8 +29,10 @@ properties: required: - compatible - reg + - regulator-min-microamp + - regulator-max-microamp -additionalProperties: false +unevaluatedProperties: false examples: - | @@ -37,6 +42,8 @@ examples: pm8150b_vbus: usb-vbus-regulator@1100 { compatible = "qcom,pm8150b-vbus-reg"; reg = <0x1100>; + regulator-min-microamp = <500000>; + regulator-max-microamp = <3000000>; }; }; ...
The VBUS driver needs to know the regulator-min-microamp and regulator-max-microamp so they should both be marked as required. regulator.yaml defines those two dependencies so include regulator.yaml. We need to change from additionalProperties: false to unevaluatedProperties: false. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../bindings/regulator/qcom,usb-vbus-regulator.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)