| Message ID | 1461335527-19270-1-git-send-email-yingjoe.chen@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
On Fri, 2016-04-22 at 22:32 +0800, Yingjoe Chen wrote: > If a Kconfig config option doesn't specify 'default', the default > will be n. Adding 'default n' is unnecessary. > > Add a test to warn about this. > > Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com> > --- > Change in v2: > - Change according to Joe Perches' suggestion > > scripts/checkpatch.pl | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index d574d13..3cb7c2d 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2600,6 +2600,13 @@ sub process { > "Use of boolean is deprecated, please use bool instead.\n" . $herecurr); > } > > +# discourage the use of default n > + if ($realfile =~ /Kconfig/ && > + $line =~ /^\+\s*default\s*n\s*(#.*|$)/i) { > + WARN("CONFIG_DEFAULT_N", > + "Use of default n is unnecessary, default is n when omitted.\n" . $herecurr); > + } > + > if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) && > ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) { > my $flag = $1; Hi, Any suggestion for this new round? Joe.C
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d574d13..3cb7c2d 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2600,6 +2600,13 @@ sub process { "Use of boolean is deprecated, please use bool instead.\n" . $herecurr); } +# discourage the use of default n + if ($realfile =~ /Kconfig/ && + $line =~ /^\+\s*default\s*n\s*(#.*|$)/i) { + WARN("CONFIG_DEFAULT_N", + "Use of default n is unnecessary, default is n when omitted.\n" . $herecurr); + } + if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) && ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) { my $flag = $1;
If a Kconfig config option doesn't specify 'default', the default will be n. Adding 'default n' is unnecessary. Add a test to warn about this. Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com> --- Change in v2: - Change according to Joe Perches' suggestion scripts/checkpatch.pl | 7 +++++++ 1 file changed, 7 insertions(+) -- 1.9.1