@@ -1579,9 +1579,21 @@ static int tgafb_setup(char *arg)
while ((this_opt = strsep(&arg, ","))) {
if (!*this_opt)
continue;
- if (!strncmp(this_opt, "mode:", 5))
- mode_option = this_opt+5;
- else
+ if (!strncmp(this_opt, "mode:", 5)) {
+ static char mode_option_buf[256];
+ int ret;
+
+ ret = snprintf(mode_option_buf, sizeof(mode_option_buf), "%s",
+ this_opt + 5);
+ if (WARN(ret < 0,
+ "tgafb: ignoring invalid option, ret=%d\n",
+ ret))
+ continue;
+ if (WARN(ret >= sizeof(mode_option_buf),
+ "tgafb: option too long\n"))
+ continue;
+ mode_option = mode_option_buf;
+ } else
printk(KERN_ERR
"tgafb: unknown parameter %s\n",
this_opt);
Assume that the driver does not own the option string or its substrings and hence duplicate the option string for the video mode. The driver only parses the option string once as part of module initialization, so use a static buffer to store the duplicated mode option. Linux automatically frees the memory upon releasing the module. Done in preparation of switching the driver to struct option_iter and constifying the option string. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/video/fbdev/tgafb.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-)