| Message ID | 1460735732-3164-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | Accepted |
| Commit | 69d0a401c92807852b503418612812242ba9f8f2 |
| Headers | show |
On Fri, Apr 15, 2016 at 12:55 PM, Mike Holmes <mike.holmes@linaro.org> wrote: > As we approach a production stable release and we package for > distribution inclusion, the default debug should be for the majority of > users to build a performance image rather than a debug one. > > Suggested-by: Anders Roxell <anders.roxell@linaro.org> > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > configure.ac | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 9665d1d..6c56daf 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -167,10 +167,12 @@ ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG_PRINT=$ODP_DEBUG_PRINT" > ########################################################################## > # Enable/disable ODP_DEBUG > ########################################################################## > -ODP_DEBUG=1 > +ODP_DEBUG=0 > AC_ARG_ENABLE([debug], > [ --enable-debug include additional code], > - [if ! test "x$enableval" = "xyes"; then > + [if test "x$enableval" = "xyes"; then > + ODP_DEBUG=1 > + else > ODP_DEBUG=0 > fi]) > ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" > -- > 2.5.0 Don't we also need to do the same for ODP_DEBUG_PRINT? Thanks,
On 15 April 2016 at 12:18, Ricardo Salveti <ricardo.salveti@linaro.org> wrote: > On Fri, Apr 15, 2016 at 12:55 PM, Mike Holmes <mike.holmes@linaro.org> > wrote: > > As we approach a production stable release and we package for > > distribution inclusion, the default debug should be for the majority of > > users to build a performance image rather than a debug one. > > > > Suggested-by: Anders Roxell <anders.roxell@linaro.org> > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > > --- > > configure.ac | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/configure.ac b/configure.ac > > index 9665d1d..6c56daf 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -167,10 +167,12 @@ ODP_CFLAGS="$ODP_CFLAGS > -DODP_DEBUG_PRINT=$ODP_DEBUG_PRINT" > > > ########################################################################## > > # Enable/disable ODP_DEBUG > > > ########################################################################## > > -ODP_DEBUG=1 > > +ODP_DEBUG=0 > > AC_ARG_ENABLE([debug], > > [ --enable-debug include additional code], > > - [if ! test "x$enableval" = "xyes"; then > > + [if test "x$enableval" = "xyes"; then > > + ODP_DEBUG=1 > > + else > > ODP_DEBUG=0 > > fi]) > > ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" > > -- > > 2.5.0 > > Don't we also need to do the same for ODP_DEBUG_PRINT? > Sure, wondered that myself, I will make a second patch to change that > > Thanks, > -- > Ricardo Salveti > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
On Fri, Apr 15, 2016 at 12:55 PM, Mike Holmes <mike.holmes@linaro.org> wrote: > As we approach a production stable release and we package for > distribution inclusion, the default debug should be for the majority of > users to build a performance image rather than a debug one. > > Suggested-by: Anders Roxell <anders.roxell@linaro.org> > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > configure.ac | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 9665d1d..6c56daf 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -167,10 +167,12 @@ ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG_PRINT=$ODP_DEBUG_PRINT" > ########################################################################## > # Enable/disable ODP_DEBUG > ########################################################################## > -ODP_DEBUG=1 > +ODP_DEBUG=0 > AC_ARG_ENABLE([debug], > [ --enable-debug include additional code], > - [if ! test "x$enableval" = "xyes"; then > + [if test "x$enableval" = "xyes"; then > + ODP_DEBUG=1 > + else > ODP_DEBUG=0 > fi]) > ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" > -- > 2.5.0 Reviewed-by: Ricardo Salveti <ricardo.salveti@linaro.org>
Ping to merge On 15 April 2016 at 14:19, Ricardo Salveti <ricardo.salveti@linaro.org> wrote: > On Fri, Apr 15, 2016 at 12:55 PM, Mike Holmes <mike.holmes@linaro.org> > wrote: > > As we approach a production stable release and we package for > > distribution inclusion, the default debug should be for the majority of > > users to build a performance image rather than a debug one. > > > > Suggested-by: Anders Roxell <anders.roxell@linaro.org> > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > > --- > > configure.ac | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/configure.ac b/configure.ac > > index 9665d1d..6c56daf 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -167,10 +167,12 @@ ODP_CFLAGS="$ODP_CFLAGS > -DODP_DEBUG_PRINT=$ODP_DEBUG_PRINT" > > > ########################################################################## > > # Enable/disable ODP_DEBUG > > > ########################################################################## > > -ODP_DEBUG=1 > > +ODP_DEBUG=0 > > AC_ARG_ENABLE([debug], > > [ --enable-debug include additional code], > > - [if ! test "x$enableval" = "xyes"; then > > + [if test "x$enableval" = "xyes"; then > > + ODP_DEBUG=1 > > + else > > ODP_DEBUG=0 > > fi]) > > ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" > > -- > > 2.5.0 > > Reviewed-by: Ricardo Salveti <ricardo.salveti@linaro.org> > > -- > Ricardo Salveti > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
Merged, Maxim. On 04/20/16 18:48, Mike Holmes wrote: > Ping to merge > > On 15 April 2016 at 14:19, Ricardo Salveti <ricardo.salveti@linaro.org > <mailto:ricardo.salveti@linaro.org>> wrote: > > On Fri, Apr 15, 2016 at 12:55 PM, Mike Holmes > <mike.holmes@linaro.org <mailto:mike.holmes@linaro.org>> wrote: > > As we approach a production stable release and we package for > > distribution inclusion, the default debug should be for the > majority of > > users to build a performance image rather than a debug one. > > > > Suggested-by: Anders Roxell <anders.roxell@linaro.org > <mailto:anders.roxell@linaro.org>> > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> > > --- > > configure.ac <http://configure.ac> | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/configure.ac <http://configure.ac> b/configure.ac > <http://configure.ac> > > index 9665d1d..6c56daf 100644 > > --- a/configure.ac <http://configure.ac> > > +++ b/configure.ac <http://configure.ac> > > @@ -167,10 +167,12 @@ ODP_CFLAGS="$ODP_CFLAGS > -DODP_DEBUG_PRINT=$ODP_DEBUG_PRINT" > > > ########################################################################## > > # Enable/disable ODP_DEBUG > > > ########################################################################## > > -ODP_DEBUG=1 > > +ODP_DEBUG=0 > > AC_ARG_ENABLE([debug], > > [ --enable-debug include additional code], > > - [if ! test "x$enableval" = "xyes"; then > > + [if test "x$enableval" = "xyes"; then > > + ODP_DEBUG=1 > > + else > > ODP_DEBUG=0 > > fi]) > > ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" > > -- > > 2.5.0 > > Reviewed-by: Ricardo Salveti <ricardo.salveti@linaro.org > <mailto:ricardo.salveti@linaro.org>> > > -- > Ricardo Salveti > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/configure.ac b/configure.ac index 9665d1d..6c56daf 100644 --- a/configure.ac +++ b/configure.ac @@ -167,10 +167,12 @@ ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG_PRINT=$ODP_DEBUG_PRINT" ########################################################################## # Enable/disable ODP_DEBUG ########################################################################## -ODP_DEBUG=1 +ODP_DEBUG=0 AC_ARG_ENABLE([debug], [ --enable-debug include additional code], - [if ! test "x$enableval" = "xyes"; then + [if test "x$enableval" = "xyes"; then + ODP_DEBUG=1 + else ODP_DEBUG=0 fi]) ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG"
As we approach a production stable release and we package for distribution inclusion, the default debug should be for the majority of users to build a performance image rather than a debug one. Suggested-by: Anders Roxell <anders.roxell@linaro.org> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- configure.ac | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)