diff mbox

[API-NEXT] linux-generic: dpdk: use renamed ODP_STATIC_ASSERT macro

Message ID 1460724492-2410-1-git-send-email-matias.elo@nokia.com
State Accepted
Commit c7563fb7464bdb7e0d6f4ffd7d47813acf05529c
Headers show

Commit Message

Elo, Matias (Nokia - FI/Espoo) April 15, 2016, 12:48 p.m. UTC
Formerly internal _ODP_STATIC_ASSERT() macro was made a full
ODP API named ODP_STATIC_ASSERT(). Update dpdk pktio to use
the new macro.

Signed-off-by: Matias Elo <matias.elo@nokia.com>
---
 platform/linux-generic/include/odp_packet_dpdk.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Bill Fischofer April 15, 2016, 12:50 p.m. UTC | #1
On Fri, Apr 15, 2016 at 7:48 AM, Matias Elo <matias.elo@nokia.com> wrote:

> Formerly internal _ODP_STATIC_ASSERT() macro was made a full

> ODP API named ODP_STATIC_ASSERT(). Update dpdk pktio to use

> the new macro.

>

> Signed-off-by: Matias Elo <matias.elo@nokia.com>

>


Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>



> ---

>  platform/linux-generic/include/odp_packet_dpdk.h | 8 ++++----

>  1 file changed, 4 insertions(+), 4 deletions(-)

>

> diff --git a/platform/linux-generic/include/odp_packet_dpdk.h

> b/platform/linux-generic/include/odp_packet_dpdk.h

> index 747ab72..31e1ed7 100644

> --- a/platform/linux-generic/include/odp_packet_dpdk.h

> +++ b/platform/linux-generic/include/odp_packet_dpdk.h

> @@ -24,10 +24,10 @@

>  #define DPDK_NM_RX_DESC  128

>  #define DPDK_NM_TX_DESC  512

>

> -_ODP_STATIC_ASSERT((DPDK_NB_MBUF % DPDK_MEMPOOL_CACHE_SIZE == 0) &&

> -                  (DPDK_MEMPOOL_CACHE_SIZE <= RTE_MEMPOOL_CACHE_MAX_SIZE)

> &&

> -                  (DPDK_MEMPOOL_CACHE_SIZE <= DPDK_MBUF_BUF_SIZE * 10 /

> 15)

> -                  , "DPDK mempool cache size failure");

> +ODP_STATIC_ASSERT((DPDK_NB_MBUF % DPDK_MEMPOOL_CACHE_SIZE == 0) &&

> +                 (DPDK_MEMPOOL_CACHE_SIZE <= RTE_MEMPOOL_CACHE_MAX_SIZE)

> &&

> +                 (DPDK_MEMPOOL_CACHE_SIZE <= DPDK_MBUF_BUF_SIZE * 10 / 15)

> +                 , "DPDK mempool cache size failure");

>  #endif

>

>  #define DPDK_IXGBE_MIN_RX_BURST 4

> --

> 1.9.1

>

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp

>
Maxim Uvarov April 15, 2016, 1:12 p.m. UTC | #2
Merged,
Maxim.

On 04/15/16 15:50, Bill Fischofer wrote:
>
>
> On Fri, Apr 15, 2016 at 7:48 AM, Matias Elo <matias.elo@nokia.com 
> <mailto:matias.elo@nokia.com>> wrote:
>
>     Formerly internal _ODP_STATIC_ASSERT() macro was made a full
>     ODP API named ODP_STATIC_ASSERT(). Update dpdk pktio to use
>     the new macro.
>
>     Signed-off-by: Matias Elo <matias.elo@nokia.com
>     <mailto:matias.elo@nokia.com>>
>
>
> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org 
> <mailto:bill.fischofer@linaro.org>>
>
>     ---
>      platform/linux-generic/include/odp_packet_dpdk.h | 8 ++++----
>      1 file changed, 4 insertions(+), 4 deletions(-)
>
>     diff --git a/platform/linux-generic/include/odp_packet_dpdk.h
>     b/platform/linux-generic/include/odp_packet_dpdk.h
>     index 747ab72..31e1ed7 100644
>     --- a/platform/linux-generic/include/odp_packet_dpdk.h
>     +++ b/platform/linux-generic/include/odp_packet_dpdk.h
>     @@ -24,10 +24,10 @@
>      #define DPDK_NM_RX_DESC  128
>      #define DPDK_NM_TX_DESC  512
>
>     -_ODP_STATIC_ASSERT((DPDK_NB_MBUF % DPDK_MEMPOOL_CACHE_SIZE == 0) &&
>     -                  (DPDK_MEMPOOL_CACHE_SIZE <=
>     RTE_MEMPOOL_CACHE_MAX_SIZE) &&
>     -                  (DPDK_MEMPOOL_CACHE_SIZE <= DPDK_MBUF_BUF_SIZE
>     * 10 / 15)
>     -                  , "DPDK mempool cache size failure");
>     +ODP_STATIC_ASSERT((DPDK_NB_MBUF % DPDK_MEMPOOL_CACHE_SIZE == 0) &&
>     +                 (DPDK_MEMPOOL_CACHE_SIZE <=
>     RTE_MEMPOOL_CACHE_MAX_SIZE) &&
>     +                 (DPDK_MEMPOOL_CACHE_SIZE <= DPDK_MBUF_BUF_SIZE *
>     10 / 15)
>     +                 , "DPDK mempool cache size failure");
>      #endif
>
>      #define DPDK_IXGBE_MIN_RX_BURST 4
>     --
>     1.9.1
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/platform/linux-generic/include/odp_packet_dpdk.h b/platform/linux-generic/include/odp_packet_dpdk.h
index 747ab72..31e1ed7 100644
--- a/platform/linux-generic/include/odp_packet_dpdk.h
+++ b/platform/linux-generic/include/odp_packet_dpdk.h
@@ -24,10 +24,10 @@ 
 #define DPDK_NM_RX_DESC  128
 #define DPDK_NM_TX_DESC  512
 
-_ODP_STATIC_ASSERT((DPDK_NB_MBUF % DPDK_MEMPOOL_CACHE_SIZE == 0) &&
-		   (DPDK_MEMPOOL_CACHE_SIZE <= RTE_MEMPOOL_CACHE_MAX_SIZE) &&
-		   (DPDK_MEMPOOL_CACHE_SIZE <= DPDK_MBUF_BUF_SIZE * 10 / 15)
-		   , "DPDK mempool cache size failure");
+ODP_STATIC_ASSERT((DPDK_NB_MBUF % DPDK_MEMPOOL_CACHE_SIZE == 0) &&
+		  (DPDK_MEMPOOL_CACHE_SIZE <= RTE_MEMPOOL_CACHE_MAX_SIZE) &&
+		  (DPDK_MEMPOOL_CACHE_SIZE <= DPDK_MBUF_BUF_SIZE * 10 / 15)
+		  , "DPDK mempool cache size failure");
 #endif
 
 #define DPDK_IXGBE_MIN_RX_BURST 4