diff mbox series

[BlueZ,1/2] lib: Add BASS UUIDs and auxiliary defines

Message ID 20230301153322.12555-2-iulia.tanasescu@nxp.com
State Superseded
Headers show
Series Add initial BASS support | expand

Commit Message

Iulia Tanasescu March 1, 2023, 3:33 p.m. UTC 
Added BASS and Audio Announcement UUIDs, added OCF for
BIG Create Sync.

---
 lib/hci.h  | 2 ++
 lib/uuid.h | 7 +++++++
 2 files changed, 9 insertions(+)

Comments

Luiz Augusto von Dentz March 1, 2023, 9:05 p.m. UTC | #1 
Hi Iulia,

On Wed, Mar 1, 2023 at 7:41 AM iulia-tanasescu <iulia.tanasescu@nxp.com> wrote:
>
> Added BASS and Audio Announcement UUIDs, added OCF for
> BIG Create Sync.
>
> ---
>  lib/hci.h  | 2 ++
>  lib/uuid.h | 7 +++++++
>  2 files changed, 9 insertions(+)
>
> diff --git a/lib/hci.h b/lib/hci.h
> index 50f385c1e..d01e6f8ee 100644
> --- a/lib/hci.h
> +++ b/lib/hci.h
> @@ -1731,6 +1731,8 @@ typedef struct {
>  } __attribute__ ((packed)) le_set_address_resolution_enable_cp;
>  #define LE_SET_ADDRESS_RESOLUTION_ENABLE_CP_SIZE 1
>
> +#define OCF_LE_BIG_CREATE_SYNC                 0x006B

We shouldn't be generating HCI commands directly from userspace,
instead we use the so called ISO socket with address set to
00:00:00:00:00:00, see isotest for a reference:

https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/tools/isotest.rst#n180
https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/tools/isotest.c#n379

>  /* Vendor specific commands */
>  #define OGF_VENDOR_CMD         0x3f
>
> diff --git a/lib/uuid.h b/lib/uuid.h
> index 84ff46cd8..a6bbc3770 100644
> --- a/lib/uuid.h
> +++ b/lib/uuid.h
> @@ -164,6 +164,13 @@ extern "C" {
>  #define ASE_SOURCE_UUID                                        0x2bc5
>  #define ASE_CP_UUID                                    0x2bc6
>
> +#define BASS_UUID                                      0x184f
> +#define BCST_AUDIO_SCAN_CP_UUID                                0x2bc7
> +#define BCST_RECV_STATE_UUID                           0x2bc8

It is probably a good idea to start with adding support to decode
these on btmon:

https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/monitor/att.c#n2475

> +
> +#define BCST_AUDIO_ANNOUNCEMENT_SERVICE_UUID           0x1852
> +#define BASIC_AUDIO_ANNOUNCEMENT_SERVICE_UUID          0x1851
> +
>  #define VCS_UUID                                       0x1844
>  #define VOL_OFFSET_CS_UUID                             0x1845
>  #define AUDIO_INPUT_CS_UUID                            0x1843
> --
> 2.34.1
diff mbox series

Patch

diff --git a/lib/hci.h b/lib/hci.h
index 50f385c1e..d01e6f8ee 100644
--- a/lib/hci.h
+++ b/lib/hci.h
@@ -1731,6 +1731,8 @@  typedef struct {
 } __attribute__ ((packed)) le_set_address_resolution_enable_cp;
 #define LE_SET_ADDRESS_RESOLUTION_ENABLE_CP_SIZE 1
 
+#define OCF_LE_BIG_CREATE_SYNC			0x006B
+
 /* Vendor specific commands */
 #define OGF_VENDOR_CMD		0x3f
 
diff --git a/lib/uuid.h b/lib/uuid.h
index 84ff46cd8..a6bbc3770 100644
--- a/lib/uuid.h
+++ b/lib/uuid.h
@@ -164,6 +164,13 @@  extern "C" {
 #define ASE_SOURCE_UUID					0x2bc5
 #define ASE_CP_UUID					0x2bc6
 
+#define BASS_UUID					0x184f
+#define BCST_AUDIO_SCAN_CP_UUID				0x2bc7
+#define BCST_RECV_STATE_UUID				0x2bc8
+
+#define BCST_AUDIO_ANNOUNCEMENT_SERVICE_UUID		0x1852
+#define BASIC_AUDIO_ANNOUNCEMENT_SERVICE_UUID		0x1851
+
 #define VCS_UUID					0x1844
 #define VOL_OFFSET_CS_UUID				0x1845
 #define AUDIO_INPUT_CS_UUID				0x1843