| Message ID | 20230226173846.236691-1-trix@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Revert "tty: serial: fsl_lpuart: adjust SERIAL_FSL_LPUART_CONSOLE config dependency" | expand |
On 2/26/23 09:38, Tom Rix wrote: > This reverts commit 5779a072c248db7a40cfd0f5ea958097fd1d9a30. > > This results in a link error of > > ld: drivers/tty/serial/earlycon.o: in function `parse_options': > drivers/tty/serial/earlycon.c:99: undefined reference to `uart_parse_earlycon' > > When the config is in this state > > CONFIG_SERIAL_CORE=m > CONFIG_SERIAL_CORE_CONSOLE=y > CONFIG_SERIAL_EARLYCON=y > CONFIG_SERIAL_FSL_LPUART=m > CONFIG_SERIAL_FSL_LPUART_CONSOLE=y > > Fixes: 5779a072c248 ("tty: serial: fsl_lpuart: adjust SERIAL_FSL_LPUART_CONSOLE config dependency") > Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > drivers/tty/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 625358f44419..0072892ca7fc 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1313,7 +1313,7 @@ config SERIAL_FSL_LPUART > > config SERIAL_FSL_LPUART_CONSOLE > bool "Console on Freescale lpuart serial port" > - depends on SERIAL_FSL_LPUART > + depends on SERIAL_FSL_LPUART=y > select SERIAL_CORE_CONSOLE > select SERIAL_EARLYCON > help
On 26. 02. 23, 18:38, Tom Rix wrote: > This reverts commit 5779a072c248db7a40cfd0f5ea958097fd1d9a30. > > This results in a link error of > > ld: drivers/tty/serial/earlycon.o: in function `parse_options': > drivers/tty/serial/earlycon.c:99: undefined reference to `uart_parse_earlycon' > > When the config is in this state > > CONFIG_SERIAL_CORE=m > CONFIG_SERIAL_CORE_CONSOLE=y > CONFIG_SERIAL_EARLYCON=y > CONFIG_SERIAL_FSL_LPUART=m > CONFIG_SERIAL_FSL_LPUART_CONSOLE=y > > Fixes: 5779a072c248 ("tty: serial: fsl_lpuart: adjust SERIAL_FSL_LPUART_CONSOLE config dependency") > Signed-off-by: Tom Rix <trix@redhat.com> Acked-by: Jiri Slaby <jirislaby@kernel.org> thanks,
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 625358f44419..0072892ca7fc 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1313,7 +1313,7 @@ config SERIAL_FSL_LPUART config SERIAL_FSL_LPUART_CONSOLE bool "Console on Freescale lpuart serial port" - depends on SERIAL_FSL_LPUART + depends on SERIAL_FSL_LPUART=y select SERIAL_CORE_CONSOLE select SERIAL_EARLYCON help
This reverts commit 5779a072c248db7a40cfd0f5ea958097fd1d9a30. This results in a link error of ld: drivers/tty/serial/earlycon.o: in function `parse_options': drivers/tty/serial/earlycon.c:99: undefined reference to `uart_parse_earlycon' When the config is in this state CONFIG_SERIAL_CORE=m CONFIG_SERIAL_CORE_CONSOLE=y CONFIG_SERIAL_EARLYCON=y CONFIG_SERIAL_FSL_LPUART=m CONFIG_SERIAL_FSL_LPUART_CONSOLE=y Fixes: 5779a072c248 ("tty: serial: fsl_lpuart: adjust SERIAL_FSL_LPUART_CONSOLE config dependency") Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)