| Message ID | 20230223231755.81633-8-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | dump: Make most of it target agnostic (build once) | expand |
Oops, "win_dump-x86.c" in subject... On 24/2/23 00:17, Philippe Mathieu-Daudé wrote: > win_dump.c is x86 specific. Rename it as such in case > someone is willing to add win_dump-aarch64 :) > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > dump/meson.build | 2 +- > dump/{win_dump.c => win_dump-x86.c} | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > rename dump/{win_dump.c => win_dump-x86.c} (99%) > > diff --git a/dump/meson.build b/dump/meson.build > index 6ae07e6fed..d899949a73 100644 > --- a/dump/meson.build > +++ b/dump/meson.build > @@ -2,5 +2,5 @@ softmmu_ss.add(files('dump-hmp-cmds.c')) > > softmmu_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, lzo]) > specific_ss.add(when: ['CONFIG_SOFTMMU', 'TARGET_X86_64'], > - if_true: files('win_dump.c'), > + if_true: files('win_dump-x86.c'), > if_false: files('win_dump-stub.c')) > diff --git a/dump/win_dump.c b/dump/win_dump-x86.c > similarity index 99% > rename from dump/win_dump.c > rename to dump/win_dump-x86.c > index ffeef4b738..5ee9a1d764 100644 > --- a/dump/win_dump.c > +++ b/dump/win_dump-x86.c > @@ -1,5 +1,5 @@ > /* > - * Windows crashdump > + * Windows crashdump for x86 targets > * > * Copyright (c) 2018 Virtuozzo International GmbH > *
On 2/23/23 13:17, Philippe Mathieu-Daudé wrote: > win_dump.c is x86 specific. Rename it as such in case > someone is willing to add win_dump-aarch64 :) I think this is premature. I would *hope* there's a lot in here that would be shared. r~
diff --git a/dump/meson.build b/dump/meson.build index 6ae07e6fed..d899949a73 100644 --- a/dump/meson.build +++ b/dump/meson.build @@ -2,5 +2,5 @@ softmmu_ss.add(files('dump-hmp-cmds.c')) softmmu_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, lzo]) specific_ss.add(when: ['CONFIG_SOFTMMU', 'TARGET_X86_64'], - if_true: files('win_dump.c'), + if_true: files('win_dump-x86.c'), if_false: files('win_dump-stub.c')) diff --git a/dump/win_dump.c b/dump/win_dump-x86.c similarity index 99% rename from dump/win_dump.c rename to dump/win_dump-x86.c index ffeef4b738..5ee9a1d764 100644 --- a/dump/win_dump.c +++ b/dump/win_dump-x86.c @@ -1,5 +1,5 @@ /* - * Windows crashdump + * Windows crashdump for x86 targets * * Copyright (c) 2018 Virtuozzo International GmbH *
win_dump.c is x86 specific. Rename it as such in case someone is willing to add win_dump-aarch64 :) Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- dump/meson.build | 2 +- dump/{win_dump.c => win_dump-x86.c} | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename dump/{win_dump.c => win_dump-x86.c} (99%)