diff mbox series

[v2,2/2] dt-bindings: serial: imx: Document mandatory clock properties

Message ID 20230219142250.10176-2-marex@denx.de
State New
Headers show
Series [v2,1/2] dt-bindings: serial: imx: Document optional DMA properties | expand

Commit Message

Marek Vasut Feb. 19, 2023, 2:22 p.m. UTC 
The UART IP must be connected to clock, document the properties in DT bindings.
Update example to match Linux arch/arm/boot/dts/imx51.dtsi .

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-serial@vger.kernel.org
---
V2: Drop the assigned-clock-*
---
 .../devicetree/bindings/serial/fsl-imx-uart.yaml  | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Krzysztof Kozlowski Feb. 20, 2023, 7:48 a.m. UTC | #1 
On 19/02/2023 15:22, Marek Vasut wrote:
> The UART IP must be connected to clock, document the properties in DT bindings.
> Update example to match Linux arch/arm/boot/dts/imx51.dtsi .
> 


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
index c22aab8c55f83..40414247d61a3 100644
--- a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
@@ -49,6 +49,14 @@  properties:
   reg:
     maxItems: 1
 
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: per
+
   dmas:
     items:
       - description: DMA controller phandle and request line for RX
@@ -96,12 +104,16 @@  properties:
 required:
   - compatible
   - reg
+  - clocks
+  - clock-names
   - interrupts
 
 unevaluatedProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/imx5-clock.h>
+
     aliases {
         serial0 = &uart1;
     };
@@ -110,6 +122,9 @@  examples:
         compatible = "fsl,imx51-uart", "fsl,imx21-uart";
         reg = <0x73fbc000 0x4000>;
         interrupts = <31>;
+        clocks = <&clks IMX5_CLK_UART1_IPG_GATE>,
+                 <&clks IMX5_CLK_UART1_PER_GATE>;
+        clock-names = "ipg", "per";
         dmas = <&sdma 18 4 1>, <&sdma 19 4 2>;
         dma-names = "rx", "tx";
         uart-has-rtscts;