| Message ID | 20230214090849.2186370-2-konrad.dybcio@linaro.org |
|---|---|
| State | Accepted |
| Commit | b2b911afd86631e601537c7dd7bb0acc0b1f9b51 |
| Headers | show |
| Series | [v2,1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible | expand |
On 14/02/2023 10:08, Konrad Dybcio wrote: > It's fine for these properties to be absent, as the driver doesn't fail > without them and functions with settings inherited from the reset/previous > stage bootloader state. > > Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi, On Wed, Feb 15, 2023 at 08:04:00PM +0100, Krzysztof Kozlowski wrote: > On 14/02/2023 10:08, Konrad Dybcio wrote: > > It's fine for these properties to be absent, as the driver doesn't fail > > without them and functions with settings inherited from the reset/previous > > stage bootloader state. > > > > Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format") > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks, queued. -- Sebastian
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml index b7b58aed3f3c..1d2405bea109 100644 --- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml @@ -28,12 +28,18 @@ properties: maxItems: 1 qcom,rset-ohms: - description: resistance (in ohms) for current-limiting resistor + description: | + Resistance (in ohms) for current-limiting resistor. If unspecified, + inherit the previous configuration (e.g. from bootloader or hardware + default value). enum: [ 800, 1200, 1700, 2100 ] qcom,vset-millivolts: $ref: /schemas/types.yaml#/definitions/uint32 - description: voltage (in millivolts) to apply for charging + description: | + Voltage (in millivolts) to apply for charging. If unspecified, inherit + the previous configuration (e.g. from bootloader or hardware default + value). enum: [ 2500, 3000, 3100, 3200 ] qcom,charger-disable: @@ -43,8 +49,6 @@ properties: required: - compatible - reg - - qcom,rset-ohms - - qcom,vset-millivolts additionalProperties: false
It's fine for these properties to be absent, as the driver doesn't fail without them and functions with settings inherited from the reset/previous stage bootloader state. Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format") Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- v1 -> v2: - Describe the behaviour when the properties are absent .../bindings/power/supply/qcom,pm8941-coincell.yaml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)