diff mbox series

crypto: qat - Include algapi.h for low-level Crypto API

Message ID Y+yZHiWPKyyR6fLw@gondor.apana.org.au
State Accepted
Commit a71b772ba063c47a3d70381dc32448cd5e324b34
Headers show
Series crypto: qat - Include algapi.h for low-level Crypto API | expand

Commit Message

Herbert Xu Feb. 15, 2023, 8:34 a.m. UTC
Include crypto/algapi.h instead of linux/crypto.h in adf_ctl_drv.c
as this is using the low-level Crypto API.  It just happens to work
currently because MODULE_ALIAS_CRYPTO was mistakenly added to
linux/crypto.h.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Comments

Cabiddu, Giovanni Feb. 23, 2023, 5:25 p.m. UTC | #1
On Wed, Feb 15, 2023 at 04:34:38PM +0800, Herbert Xu wrote:
> Include crypto/algapi.h instead of linux/crypto.h in adf_ctl_drv.c
> as this is using the low-level Crypto API.  It just happens to work
> currently because MODULE_ALIAS_CRYPTO was mistakenly added to
> linux/crypto.h.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
diff mbox series

Patch

diff --git a/drivers/crypto/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
index 9190532b27eb..f030d8a85252 100644
--- a/drivers/crypto/qat/qat_common/adf_ctl_drv.c
+++ b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
@@ -1,5 +1,7 @@ 
 // SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0-only)
 /* Copyright(c) 2014 - 2020 Intel Corporation */
+
+#include <crypto/algapi.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/slab.h>
@@ -8,7 +10,6 @@ 
 #include <linux/pci.h>
 #include <linux/cdev.h>
 #include <linux/uaccess.h>
-#include <linux/crypto.h>
 
 #include "adf_accel_devices.h"
 #include "adf_common_drv.h"