| Message ID | 20230214172716.4106-1-darrell.kavanagh@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | firmware/efi sysfb_efi: Add quirk for Lenovo IdeaPad Duet 3 | expand |
Hi, On 2/14/23 18:27, Darrell Kavanagh wrote: > Another Lenovo convertable where the panel reports incorrect orientation > to the kernel For sysfb_efi.c the problem is not that it reports incorrect orientation (efifb does not do anything with rotation) but that it reports the wrong resolution and pitch. It reports a landscape resolution of 1920x1200 with a pitch of (1920 * 4) bytes. While the actual framebuffer has a resolution of 1200x1920 with a pitch of (1200 * 4) bytes. Can you please send a v2 with an updated commit message explaining this? > Signed-off-by: Darrell Kavanagh <darrell.kavanagh@gmail.com> Note for v2 it is customary to add something like the following after your S-o-b: """ --- Changes in v2: - Improve commit message """ Regards, Hans > > --- > drivers/firmware/efi/sysfb_efi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c > index 7882d4b3f2be..f06fdacc9bc8 100644 > --- a/drivers/firmware/efi/sysfb_efi.c > +++ b/drivers/firmware/efi/sysfb_efi.c > @@ -264,6 +264,14 @@ static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = { > "Lenovo ideapad D330-10IGM"), > }, > }, > + { > + /* Lenovo IdeaPad Duet 3 10IGL5 with 1200x1920 portrait screen */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, > + "IdeaPad Duet 3 10IGL5"), > + }, > + }, > {}, > }; >
diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c index 7882d4b3f2be..f06fdacc9bc8 100644 --- a/drivers/firmware/efi/sysfb_efi.c +++ b/drivers/firmware/efi/sysfb_efi.c @@ -264,6 +264,14 @@ static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = { "Lenovo ideapad D330-10IGM"), }, }, + { + /* Lenovo IdeaPad Duet 3 10IGL5 with 1200x1920 portrait screen */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, + "IdeaPad Duet 3 10IGL5"), + }, + }, {}, };
Another Lenovo convertable where the panel reports incorrect orientation to the kernel Signed-off-by: Darrell Kavanagh <darrell.kavanagh@gmail.com> --- drivers/firmware/efi/sysfb_efi.c | 8 ++++++++ 1 file changed, 8 insertions(+)