diff mbox series

[2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties

Message ID 20230213204950.2100538-2-konrad.dybcio@linaro.org
State New
Headers show
Series [1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible | expand

Commit Message

Konrad Dybcio Feb. 13, 2023, 8:49 p.m. UTC
It's fine for these properties to be absent, as the driver doesn't fail
without them and functions with settings inherited from the reset/previous
stage bootloader state.

Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 .../devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml  | 2 --
 1 file changed, 2 deletions(-)

Comments

Sebastian Reichel Feb. 13, 2023, 9:27 p.m. UTC | #1
Hi,

On Mon, Feb 13, 2023 at 09:49:49PM +0100, Konrad Dybcio wrote:
> It's fine for these properties to be absent, as the driver doesn't fail
> without them and functions with settings inherited from the reset/previous
> stage bootloader state.
> 
> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---

Please update the description of these properties to describe the
default behaviour.

-- Sebastian

>  .../devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml  | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> index b7b58aed3f3c..d62e3af55560 100644
> --- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> @@ -43,8 +43,6 @@ properties:
>  required:
>    - compatible
>    - reg
> -  - qcom,rset-ohms
> -  - qcom,vset-millivolts
>  
>  additionalProperties: false
>  
> -- 
> 2.39.1
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
index b7b58aed3f3c..d62e3af55560 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
@@ -43,8 +43,6 @@  properties:
 required:
   - compatible
   - reg
-  - qcom,rset-ohms
-  - qcom,vset-millivolts
 
 additionalProperties: false