| Message ID | 20230210111228.370513-1-n.petrova@fintech.ru |
|---|---|
| State | New |
| Headers | show |
| Series | b43legacy: Add checking for null for ssb_get_devtypedata(dev) | expand |
diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c index 760136638a95..1ae65679d704 100644 --- a/drivers/net/wireless/broadcom/b43legacy/main.c +++ b/drivers/net/wireless/broadcom/b43legacy/main.c @@ -3871,7 +3871,7 @@ static int b43legacy_probe(struct ssb_device *dev, return err; err_wireless_exit: - if (first) + if (first && wl) b43legacy_wireless_exit(dev, wl); return err; }
Function ssb_get_devtypedata(dev) may return null (next call B43legacy_WARN_ON(!wl) is used for error handling, including null-value). Therefore, a check is added before calling b43legacy_wireless_exit(), where the argument containing this value is expected to be dereferenced. Found by Linux Verification Center (linuxtesting.org) with SVACE Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices") Signed-off-by: Natalia Petrova <n.petrova@fintech.ru> --- drivers/net/wireless/broadcom/b43legacy/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)