| Message ID | 3df45c4a6737b249b519d4c6128e2eb783198abc.1676112710.git.pav@iki.fi |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ,v2,1/9] doc: remove unimplemented Quality Report from MGMT settings | expand |
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sat, 11 Feb 2023 10:53:45 +0000 you wrote: > The Set Quality Report command was removed in > commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), > but the settings bit was not removed. It's also not implemented on > kernel side, so remove it now. > --- > > Notes: > v2: split to two commits > > [...] Here is the summary with links: - [BlueZ,v2,1/9] doc: remove unimplemented Quality Report from MGMT settings https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3e2e3aa73904 - [BlueZ,v2,2/9] doc: add MGMT setting for CIS features https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=97ad0ecbfdd4 - [BlueZ,v2,3/9] lib: Add defines for MGMT setting bits for CIS feature support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c35d32b19989 - [BlueZ,v2,4/9] monitor: add MGMT setting bit names for CIS feature support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0f2f7a8fe270 - [BlueZ,v2,5/9] tools/btmgmt: add MGMT setting bit names for CIS feature support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6f131929b832 - [BlueZ,v2,6/9] adapter: add function for checking adapter features, add CIS features (no matching commit) - [BlueZ,v2,7/9] media: Check adapter CIS support to add BAP in SupportedUUIDs (no matching commit) - [BlueZ,v2,8/9] shared/bap: support client-only case (no matching commit) - [BlueZ,v2,9/9] bap: handle adapters that are not CIS Central / Peripheral capable (no matching commit) You are awesome, thank you!
Hi Pauli, On Mon, Feb 13, 2023 at 2:21 PM <patchwork-bot+bluetooth@kernel.org> wrote: > > Hello: > > This series was applied to bluetooth/bluez.git (master) > by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: > > On Sat, 11 Feb 2023 10:53:45 +0000 you wrote: > > The Set Quality Report command was removed in > > commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), > > but the settings bit was not removed. It's also not implemented on > > kernel side, so remove it now. > > --- > > > > Notes: > > v2: split to two commits > > > > [...] > > Here is the summary with links: > - [BlueZ,v2,1/9] doc: remove unimplemented Quality Report from MGMT settings > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3e2e3aa73904 > - [BlueZ,v2,2/9] doc: add MGMT setting for CIS features > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=97ad0ecbfdd4 > - [BlueZ,v2,3/9] lib: Add defines for MGMT setting bits for CIS feature support > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c35d32b19989 > - [BlueZ,v2,4/9] monitor: add MGMT setting bit names for CIS feature support > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0f2f7a8fe270 > - [BlueZ,v2,5/9] tools/btmgmt: add MGMT setting bit names for CIS feature support > https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6f131929b832 > - [BlueZ,v2,6/9] adapter: add function for checking adapter features, add CIS features > (no matching commit) > - [BlueZ,v2,7/9] media: Check adapter CIS support to add BAP in SupportedUUIDs > (no matching commit) > - [BlueZ,v2,8/9] shared/bap: support client-only case > (no matching commit) > - [BlueZ,v2,9/9] bap: handle adapters that are not CIS Central / Peripheral capable > (no matching commit) > > You are awesome, thank you! Note that I did change some of the commits, for instance I went with btd_adapter_has_settings so we can use the MGMT defines directly, instead of creating a new enum.
diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt index 90d612ed8..0e0b4fdf0 100644 --- a/doc/mgmt-api.txt +++ b/doc/mgmt-api.txt @@ -332,7 +332,6 @@ Read Controller Information Command 15 Static Address 16 PHY Configuration 17 Wideband Speech - 18 Quality Report This command generates a Command Complete event on success or a Command Status event on failure. @@ -2925,7 +2924,6 @@ Read Extended Controller Information Command 15 Static Address 16 PHY Configuration 17 Wideband Speech - 18 Quality Report The EIR_Data field contains information about class of device, local name and other values. Not all of them might be present. For
The Set Quality Report command was removed in commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), but the settings bit was not removed. It's also not implemented on kernel side, so remove it now. --- Notes: v2: split to two commits doc/mgmt-api.txt | 2 -- 1 file changed, 2 deletions(-)