| Message ID | 20230201154321.276419-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings | expand |
On 1.02.2023 16:43, Krzysztof Kozlowski wrote: > Bindings expect pins to be named with certain pattern. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- Do we want a Fixes: here? Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > Endless work... People keep sending patches without running dtbs_check > faster than I am fixing existing warnings. > --- > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > index df841230d1b7..ece1a7cb8b3b 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > @@ -723,7 +723,7 @@ usb_hub_enabled_state: usb-hub-enabled-state { > }; > > lt9611_state: lt9611-state { > - rst { > + rst-pins { > pins = "gpio48"; > function = "normal"; > > @@ -731,7 +731,7 @@ rst { > input-disable; > }; > > - irq { > + irq-pins { > pins = "gpio50"; > function = "gpio"; > bias-disable;
On 01/02/2023 16:47, Konrad Dybcio wrote: > > > On 1.02.2023 16:43, Krzysztof Kozlowski wrote: >> SM8350 pin controller does not have "normal" pin function, so use >> "gpio". >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > Makes one wonder if it was ever tested, as this would have probably > failed when setting pinctrl settings.. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Fixes: d96d8f9192be ("arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge") Best regards, Krzysztof
On 01/02/2023 16:46, Konrad Dybcio wrote: > > > On 1.02.2023 16:43, Krzysztof Kozlowski wrote: >> Bindings expect pins to be named with certain pattern. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> --- > Do we want a Fixes: here? > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Could be: Fixes: d96d8f9192be ("arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge") Best regards, Krzysztof
On Wed, 1 Feb 2023 16:43:19 +0100, Krzysztof Kozlowski wrote: > Bindings expect pins to be named with certain pattern. > > Applied, thanks! [1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings commit: 9927f8a59f42b6c0bde9ba770ffe9d9d9bce79da [2/3] arm64: dts: qcom: sm8350-hdk: correct LT9611 pin function commit: cd06d923304355762d426b030a30d99fdf765b84 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts index df841230d1b7..ece1a7cb8b3b 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts @@ -723,7 +723,7 @@ usb_hub_enabled_state: usb-hub-enabled-state { }; lt9611_state: lt9611-state { - rst { + rst-pins { pins = "gpio48"; function = "normal"; @@ -731,7 +731,7 @@ rst { input-disable; }; - irq { + irq-pins { pins = "gpio50"; function = "gpio"; bias-disable;
Bindings expect pins to be named with certain pattern. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Endless work... People keep sending patches without running dtbs_check faster than I am fixing existing warnings. --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)