| Message ID | 20230131140304.626779-1-clabbe@baylibre.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v5,1/2] dt-bindings: leds: common: add disk write/read and usb-host/usb-gadget | expand |
On Tue, Jan 31, 2023 at 3:03 PM Corentin Labbe <clabbe@baylibre.com> wrote: > No user of ide-disk remains, so remove this deprecated trigger. > Only a few platforms used this and were fixed in 2016. > > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, 31 Jan 2023, Corentin Labbe wrote: > The triggers enum misses 3 cases used by gemini DT. > usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity") > so we add also as valid trigger usb-gadget which was added along in this > commit. > > disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes") > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Acked-by: Rob Herring <robh@kernel.org> > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> Applied, thanks
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index d34bb58c0037..60c8611c6611 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -90,6 +90,8 @@ properties: - heartbeat # LED indicates disk activity - disk-activity + - disk-read + - disk-write # LED indicates IDE disk activity (deprecated), in new implementations # use "disk-activity" - ide-disk @@ -98,6 +100,8 @@ properties: # LED alters the brightness for the specified duration with one software # timer (requires "led-pattern" property) - pattern + - usb-gadget + - usb-host - pattern: "^cpu[0-9]*$" - pattern: "^hci[0-9]+-power$" # LED is triggered by Bluetooth activity
The triggers enum misses 3 cases used by gemini DT. usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity") so we add also as valid trigger usb-gadget which was added along in this commit. disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes") Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- V1 can be seen at https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210508193654.2596119-1-clabbe@baylibre.com/ Changes since v1: - rebased on recent tree Changes since v2: - rebased on recent tree Changes since v3: - rebased on recent tree Changes since v4: - rebased on recent tree Documentation/devicetree/bindings/leds/common.yaml | 4 ++++ 1 file changed, 4 insertions(+)