| Message ID | 20230127212713.267014-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFT,v3,1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250 | expand |
On 27.01.2023 22:27, Krzysztof Kozlowski wrote: > Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node > which do not have unit address. Therefore usethe address space > of child device (actual DWC3 Controller) as the wrapper's address to > fix: > > exynos5422-odroidhc1.dtb: soc: usb3-0: {'compatible': ['samsung,exynos5250-dwusb3'], > ... } should not be valid under {'type': 'object'} > > exynos54xx.dtsi:145.21-159.5: Warning (simple_bus_reg): /soc/usb3-0: missing or empty reg/ranges property > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > > Changes since v1: > 1. Use ranges with values and drop reg from usb-wrapper node. > 2. Keep "usb" as wrapper's node name. > --- > arch/arm/boot/dts/exynos54xx.dtsi | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi > index 3ec43761d8b9..5c799886c275 100644 > --- a/arch/arm/boot/dts/exynos54xx.dtsi > +++ b/arch/arm/boot/dts/exynos54xx.dtsi > @@ -142,15 +142,15 @@ hsi2c_7: i2c@12cd0000 { > status = "disabled"; > }; > > - usbdrd3_0: usb3-0 { > + usbdrd3_0: usb@12000000 { > compatible = "samsung,exynos5250-dwusb3"; > #address-cells = <1>; > #size-cells = <1>; > - ranges; > + ranges = <0x0 0x12000000 0x10000>; > > - usbdrd_dwc3_0: usb@12000000 { > + usbdrd_dwc3_0: usb@0 { > compatible = "snps,dwc3"; > - reg = <0x12000000 0x10000>; > + reg = <0x0 0x10000>; > interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > phys = <&usbdrd_phy0 0>, <&usbdrd_phy0 1>; > phy-names = "usb2-phy", "usb3-phy"; > @@ -164,15 +164,15 @@ usbdrd_phy0: phy@12100000 { > #phy-cells = <1>; > }; > > - usbdrd3_1: usb3-1 { > + usbdrd3_1: usb@12400000 { > compatible = "samsung,exynos5250-dwusb3"; > #address-cells = <1>; > #size-cells = <1>; > - ranges; > + ranges = <0x0 0x12400000 0x10000>; > > - usbdrd_dwc3_1: usb@12400000 { > + usbdrd_dwc3_1: usb@0 { > compatible = "snps,dwc3"; > - reg = <0x12400000 0x10000>; > + reg = <0x0 0x10000>; > phys = <&usbdrd_phy1 0>, <&usbdrd_phy1 1>; > phy-names = "usb2-phy", "usb3-phy"; > snps,dis_u3_susphy_quirk; Best regards
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Saturday, January 28, 2023 2:57 AM > To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar > <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org > Cc: replicant@osuosl.org; phone-devel@vger.kernel.org; > ~postmarketos/upstreaming@lists.sr.ht; Martin Jücker > <martin.juecker@gmail.com>; Henrik Grimler <henrik@grimler.se>; Sam > Protsenko <semen.protsenko@linaro.org>; Chanho Park > <chanho61.park@samsung.com>; Marek Szyprowski > <m.szyprowski@samsung.com>; Chanwoo Choi > <cw00.choi@samsung.com>; Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> > Subject: [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3 > node wrapper in Exynos7 > > Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node > which do not have unit address. Therefore usethe address space of child > device (actual DWC3 Controller) as the wrapper's address to > fix: > > exynos7-espresso.dtb: soc@0: usb: {'compatible': ['samsung,exynos7- > dwusb3'], ... > should not be valid under {'type': 'object'} > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> Tested on exynos7-espresso and xHCI driver still gets probed, so Tested-by: Alim Akhtar <alim.akhtar@samsung.com> > > Changes since v1: > 1. New patch > --- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi > b/arch/arm64/boot/dts/exynos/exynos7.dtsi > index 82fee1b7caab..b1fa68835b09 100644 > --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi > @@ -690,7 +690,7 @@ usbdrd_phy: phy@15500000 { > #phy-cells = <1>; > }; > > - usbdrd: usb { > + usbdrd: usb@15400000 { > compatible = "samsung,exynos7-dwusb3"; > clocks = <&clock_fsys0 ACLK_USBDRD300>, > <&clock_fsys0 SCLK_USBDRD300_SUSPENDCLK>, > @@ -699,11 +699,11 @@ usbdrd: usb { > "usbdrd30_axius_clk"; > #address-cells = <1>; > #size-cells = <1>; > - ranges; > + ranges = <0x0 0x15400000 0x10000>; > > - usb@15400000 { > + usb@0 { > compatible = "snps,dwc3"; > - reg = <0x15400000 0x10000>; > + reg = <0x0 0x10000>; > interrupts = <GIC_SPI 223 > IRQ_TYPE_LEVEL_HIGH>; > phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>; > phy-names = "usb2-phy", "usb3-phy"; > -- > 2.34.1
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 97e89859ba3d..a5db4ac213d5 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -635,17 +635,17 @@ i2s2: i2s@12d70000 { #sound-dai-cells = <1>; }; - usbdrd: usb3 { + usbdrd: usb@12000000 { compatible = "samsung,exynos5250-dwusb3"; clocks = <&clock CLK_USB3>; clock-names = "usbdrd30"; #address-cells = <1>; #size-cells = <1>; - ranges; + ranges = <0x0 0x12000000 0x10000>; - usbdrd_dwc3: usb@12000000 { + usbdrd_dwc3: usb@0 { compatible = "snps,dwc3"; - reg = <0x12000000 0x10000>; + reg = <0x0 0x10000>; interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>; phy-names = "usb2-phy", "usb3-phy";
Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node which do not have unit address. Therefore usethe address space of child device (actual DWC3 Controller) as the wrapper's address to fix: exynos5250-smdk5250.dtb: soc: usb3: {'compatible': ['samsung,exynos5250-dwusb3'], ... } should not be valid under {'type': 'object'} exynos5250.dtsi:638.16-653.5: Warning (simple_bus_reg): /soc/usb3: missing or empty reg/ranges property Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v1: 1. Use ranges with values and drop reg from usb-wrapper node. 2. Keep "usb" as wrapper's node name. --- arch/arm/boot/dts/exynos5250.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)