| Message ID | 20230123084300.22353-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 077d29e81963b415e49216878563e933d346efa2 |
| Headers | show |
| Series | [RFT,v3,1/6] arm64: dts: qcom: sdm845-db845c: add generic sound compatible | expand |
On 1/23/23 08:42, Krzysztof Kozlowski wrote: > Re-organize SDM845 audio codec into separate, audio DTSI which > should be included and customized by the SDM845 boards wanting audio. > The codec node is anyway not a property of the SoC, but the boards. > > On all others boards not using audio, keep the Slimbus node disabled as > it is empty. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org> I'll give this a spin later and resend OnePlus 6 support. > > --- > > Changes since v2: > 1. Drop sound node in DTSI - affects devices. > 2. Drop "audio" from DTSI file name. > > Changes since v1: > 1. Move also sound node. > 2. Rewrite commit msg. > > RFC - please kindly test the boards. -- Kind Regards, Caleb (they/them)
On Mon, 23 Jan 2023 09:42:55 +0100, Krzysztof Kozlowski wrote: > Use generic sound card fallback compatible, because the device is > actually fully compatible with the generic one. > > Applied, thanks! [1/6] arm64: dts: qcom: sdm845-db845c: add generic sound compatible commit: 077d29e81963b415e49216878563e933d346efa2 [2/6] arm64: dts: qcom: sdm845-xiaomi-beryllium: add generic sound compatible commit: f7c45f3d87a1a2639db67dbdbaf533e20337344e [3/6] arm64: dts: qcom: sdm850-lenovo-yoga: correct sound compatible commit: 099f035d03d2318f5a7edb0305d178c7206fd820 [4/6] arm64: dts: qcom: sdm845: move codec to separate file commit: 34c861737720f89593adb6a4eab1d117b602510f [5/6] arm64: dts: qcom: sdm845-audio-wcd9340: commonize pinctrl commit: 71c461a325e35bba0481bfacc40209c4d7189cc1 [6/6] arm64: dts: qcom: sdm845-audio-wcd9340: commonize clocks commit: 47a17dfb65a2caf4fb079102d2ad7c90c393322a Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index 0d935c928148..4833e89affc2 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -704,7 +704,7 @@ &sdhc_2 { }; &sound { - compatible = "qcom,db845c-sndcard"; + compatible = "qcom,db845c-sndcard", "qcom,sdm845-sndcard"; pinctrl-0 = <&quat_mi2s_active &quat_mi2s_sd0_active &quat_mi2s_sd1_active
Use generic sound card fallback compatible, because the device is actually fully compatible with the generic one. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v2: 1. None Changes since v1: 1. New patch Bindings: https://lore.kernel.org/alsa-devel/20230118101542.96705-1-krzysztof.kozlowski@linaro.org/T/#t --- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)