| Message ID | 20230120155404.323386-6-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: exynos: DT schema fixes | expand |
Hi, I see you have already merged this, but FWIW HDMI works as well as before on exynos4412-i9300, so: Tested-by: Henrik Grimler <henrik@grimler.se> Longer explanation: HDMI output only works on i9300 if MHL cable is attached before device boots, so probably bootloader sets up some settings that the sii9234 driver does not handle (correctly) if cable is hot plugged. Best regards, Henrik Grimler On Fri, Jan 20, 2023 at 04:53:58PM +0100, Krzysztof Kozlowski wrote: > The SII9234 HDMI bridge expects ports property: > > exynos4412-i9305.dtb: hdmi-bridge@39: 'ports' is a required property > exynos4412-i9305.dtb: hdmi-bridge@39: 'port' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm/boot/dts/exynos4412-midas.dtsi | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi > index 8e1c19a8ad06..a626d33d1330 100644 > --- a/arch/arm/boot/dts/exynos4412-midas.dtsi > +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi > @@ -273,9 +273,16 @@ sii9234: hdmi-bridge@39 { > interrupts = <5 IRQ_TYPE_LEVEL_HIGH>; > reg = <0x39>; > > - port { > - mhl_to_hdmi: endpoint { > - remote-endpoint = <&hdmi_to_mhl>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + mhl_to_hdmi: endpoint { > + remote-endpoint = <&hdmi_to_mhl>; > + }; > }; > }; > }; > -- > 2.34.1 >
On 23/01/2023 16:34, Henrik Grimler wrote: > Hi, > > I see you have already merged this, but FWIW HDMI works as well as > before on exynos4412-i9300, so: > > Tested-by: Henrik Grimler <henrik@grimler.se> Great, thanks! I'll add your tag. > > Longer explanation: HDMI output only works on i9300 if MHL cable is > attached before device boots, so probably bootloader sets up some > settings that the sii9234 driver does not handle (correctly) if cable > is hot plugged. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi index 8e1c19a8ad06..a626d33d1330 100644 --- a/arch/arm/boot/dts/exynos4412-midas.dtsi +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi @@ -273,9 +273,16 @@ sii9234: hdmi-bridge@39 { interrupts = <5 IRQ_TYPE_LEVEL_HIGH>; reg = <0x39>; - port { - mhl_to_hdmi: endpoint { - remote-endpoint = <&hdmi_to_mhl>; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + mhl_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_mhl>; + }; }; }; };
The SII9234 HDMI bridge expects ports property: exynos4412-i9305.dtb: hdmi-bridge@39: 'ports' is a required property exynos4412-i9305.dtb: hdmi-bridge@39: 'port' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/exynos4412-midas.dtsi | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)