| Message ID | 20230120154437.22025-5-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/5] usb: fotg210-hcd: use sysfs_emit() to instead of scnprintf() | expand |
On Fri, Jan 20, 2023 at 4:44 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Convert platform_get_resource(), devm_ioremap_resource() to a single > call to devm_platform_get_and_ioremap_resource(), as this is exactly > what this function does. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Thu, Jan 26, 2023 at 09:02:30PM +0100, Linus Walleij wrote: > On Fri, Jan 20, 2023 at 4:44 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: ... > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Thanks for all your reviews! But I think you are a bit late with them as Greg applied the series like a couple of days ago.
On Fri, Jan 27, 2023 at 9:55 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Thu, Jan 26, 2023 at 09:02:30PM +0100, Linus Walleij wrote: > > On Fri, Jan 20, 2023 at 4:44 PM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > ... > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Thanks for all your reviews! > > But I think you are a bit late with them as Greg applied the series like > a couple of days ago. Yeah he's so quick and I'm so slow... But these days we record the mail thread link to lore in the commit so I can still share the blame ;) Yours, Linus Walleij
On Fri, Jan 27, 2023 at 10:10:11AM +0100, Linus Walleij wrote: > On Fri, Jan 27, 2023 at 9:55 AM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > On Thu, Jan 26, 2023 at 09:02:30PM +0100, Linus Walleij wrote: > > > On Fri, Jan 20, 2023 at 4:44 PM Andy Shevchenko > > > <andriy.shevchenko@linux.intel.com> wrote: ... > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > > > Thanks for all your reviews! > > > > But I think you are a bit late with them as Greg applied the series like > > a couple of days ago. > > Yeah he's so quick and I'm so slow... > But these days we record the mail thread link to lore in the > commit so I can still share the blame ;) Right, what I meant is not diminish your efforts, but to say that they won't make Git history.
diff --git a/drivers/usb/fotg210/fotg210-core.c b/drivers/usb/fotg210/fotg210-core.c index ce00d9407ce5..202d80adca2c 100644 --- a/drivers/usb/fotg210/fotg210-core.c +++ b/drivers/usb/fotg210/fotg210-core.c @@ -135,11 +135,7 @@ static int fotg210_probe(struct platform_device *pdev) return -ENOMEM; fotg->dev = dev; - fotg->res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!fotg->res) - return -ENODEV; - - fotg->base = devm_ioremap_resource(dev, fotg->res); + fotg->base = devm_platform_get_and_ioremap_resource(pdev, 0, &fotg->res); if (!fotg->base) return -ENOMEM;
Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/usb/fotg210/fotg210-core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)