| Message ID | 20230120074204.1368-1-nicolinc@nvidia.com |
|---|---|
| State | Accepted |
| Commit | 9fabbdf338b701f2d763d9edbc3e82ce1e7fa1b4 |
| Headers | show |
| Series | selftests: iommu: Fix test_cmd_destroy_access() call in user_copy | expand |
> From: Nicolin Chen <nicolinc@nvidia.com> > Sent: Friday, January 20, 2023 3:42 PM > > The test_cmd_destroy_access() should end with a semicolon, so add one. > There is a test_ioctl_destroy(ioas_id) following already, so drop one. > > Fixes: 57f0988706fe ("iommufd: Add a selftest") > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
On Thu, Jan 19, 2023 at 11:42:04PM -0800, Nicolin Chen wrote: > The test_cmd_destroy_access() should end with a semicolon, so add one. > There is a test_ioctl_destroy(ioas_id) following already, so drop one. > > Fixes: 57f0988706fe ("iommufd: Add a selftest") > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com> > --- > tools/testing/selftests/iommu/iommufd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied thanks Jason
diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selftests/iommu/iommufd.c index 8aa8a346cf22..fa08209268c4 100644 --- a/tools/testing/selftests/iommu/iommufd.c +++ b/tools/testing/selftests/iommu/iommufd.c @@ -1259,7 +1259,7 @@ TEST_F(iommufd_mock_domain, user_copy) test_cmd_destroy_access_pages( access_cmd.id, access_cmd.access_pages.out_access_pages_id); - test_cmd_destroy_access(access_cmd.id) test_ioctl_destroy(ioas_id); + test_cmd_destroy_access(access_cmd.id); test_ioctl_destroy(ioas_id); }
The test_cmd_destroy_access() should end with a semicolon, so add one. There is a test_ioctl_destroy(ioas_id) following already, so drop one. Fixes: 57f0988706fe ("iommufd: Add a selftest") Signed-off-by: Nicolin Chen <nicolinc@nvidia.com> --- tools/testing/selftests/iommu/iommufd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)