Message ID | 20230119094447.21939-2-walker.chen@starfivetech.com |
---|---|
State | Superseded |
Headers | show |
Series | JH7110 PMU Support | expand |
Hey Walker, On Thu, Jan 19, 2023 at 05:44:46PM +0800, Walker Chen wrote: > Add bindings for the Power Management Unit on the StarFive JH7110 SoC. > > Signed-off-by: Walker Chen <walker.chen@starfivetech.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Just FYI, an R-b given against the cover letter can usually be applied to all patches in the series, unless otherwise stated. So here's mine from v3: Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Whenever you re-submit the dts patch, you can send that with my R-b already applied there too. I'll give this a day or two for the build bots to look at it before applying it. Thanks, Conor. > --- > .../bindings/power/starfive,jh7110-pmu.yaml | 45 +++++++++++++++++++ > .../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++ > 2 files changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml > create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h > > diff --git a/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml b/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml > new file mode 100644 > index 000000000000..98eb8b4110e7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/starfive,jh7110-pmu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH7110 Power Management Unit > + > +maintainers: > + - Walker Chen <walker.chen@starfivetech.com> > + > +description: | > + StarFive JH7110 SoC includes support for multiple power domains which can be > + powered on/off by software based on different application scenes to save power. > + > +properties: > + compatible: > + enum: > + - starfive,jh7110-pmu > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + "#power-domain-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - "#power-domain-cells" > + > +additionalProperties: false > + > +examples: > + - | > + pwrc: power-controller@17030000 { > + compatible = "starfive,jh7110-pmu"; > + reg = <0x17030000 0x10000>; > + interrupts = <111>; > + #power-domain-cells = <1>; > + }; > diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h > new file mode 100644 > index 000000000000..132bfe401fc8 > --- /dev/null > +++ b/include/dt-bindings/power/starfive,jh7110-pmu.h > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (C) 2022 StarFive Technology Co., Ltd. > + * Author: Walker Chen <walker.chen@starfivetech.com> > + */ > +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ > +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ > + > +#define JH7110_PD_SYSTOP 0 > +#define JH7110_PD_CPU 1 > +#define JH7110_PD_GPUA 2 > +#define JH7110_PD_VDEC 3 > +#define JH7110_PD_VOUT 4 > +#define JH7110_PD_ISP 5 > +#define JH7110_PD_VENC 6 > + > +#endif > -- > 2.17.1 > >
On 2023/1/19 19:59, Heiko Stuebner wrote: > Am Donnerstag, 19. Januar 2023, 10:44:46 CET schrieb Walker Chen: >> Add bindings for the Power Management Unit on the StarFive JH7110 SoC. >> >> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> Thank you very much for your support! Best regards, Walker
diff --git a/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml b/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml new file mode 100644 index 000000000000..98eb8b4110e7 --- /dev/null +++ b/Documentation/devicetree/bindings/power/starfive,jh7110-pmu.yaml @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/starfive,jh7110-pmu.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: StarFive JH7110 Power Management Unit + +maintainers: + - Walker Chen <walker.chen@starfivetech.com> + +description: | + StarFive JH7110 SoC includes support for multiple power domains which can be + powered on/off by software based on different application scenes to save power. + +properties: + compatible: + enum: + - starfive,jh7110-pmu + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + "#power-domain-cells": + const: 1 + +required: + - compatible + - reg + - interrupts + - "#power-domain-cells" + +additionalProperties: false + +examples: + - | + pwrc: power-controller@17030000 { + compatible = "starfive,jh7110-pmu"; + reg = <0x17030000 0x10000>; + interrupts = <111>; + #power-domain-cells = <1>; + }; diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h new file mode 100644 index 000000000000..132bfe401fc8 --- /dev/null +++ b/include/dt-bindings/power/starfive,jh7110-pmu.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (C) 2022 StarFive Technology Co., Ltd. + * Author: Walker Chen <walker.chen@starfivetech.com> + */ +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ + +#define JH7110_PD_SYSTOP 0 +#define JH7110_PD_CPU 1 +#define JH7110_PD_GPUA 2 +#define JH7110_PD_VDEC 3 +#define JH7110_PD_VOUT 4 +#define JH7110_PD_ISP 5 +#define JH7110_PD_VENC 6 + +#endif