diff mbox

ARM: devicetree: Add .dtb files to arch/arm/boot/.gitignore

Message ID 1327945574-7977-1-git-send-email-dave.martin@linaro.org
State Accepted
Headers show

Commit Message

Dave Martin Jan. 30, 2012, 5:46 p.m. UTC
Compiled device tree blobs shouldn't be committed in the kernel
tree, so ideally git should ignore them.

This patch will enable ignoring of any .dtb files which appear in
arch/arm/boot/

Signed-off-by: Dave Martin <dave.martin@linaro.org>
---
 arch/arm/boot/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Shawn Guo Jan. 31, 2012, 3:20 a.m. UTC | #1
On Mon, Jan 30, 2012 at 05:46:14PM +0000, Dave Martin wrote:
> Compiled device tree blobs shouldn't be committed in the kernel
> tree, so ideally git should ignore them.
> 
> This patch will enable ignoring of any .dtb files which appear in
> arch/arm/boot/
> 
> Signed-off-by: Dave Martin <dave.martin@linaro.org>

Acked-by: Shawn Guo <shawn.guo@linaro.org>

I added my ack tag on the same patch below, but it died in the end?

http://comments.gmane.org/gmane.linux.ports.arm.kernel/144097

Regards,
Shawn

> ---
>  arch/arm/boot/.gitignore |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
> index ce1c5ff..3c79f85 100644
> --- a/arch/arm/boot/.gitignore
> +++ b/arch/arm/boot/.gitignore
> @@ -3,3 +3,4 @@ zImage
>  xipImage
>  bootpImage
>  uImage
> +*.dtb
> -- 
> 1.7.4.1
Dave Martin Jan. 31, 2012, 11:46 a.m. UTC | #2
On Tue, Jan 31, 2012 at 11:20:24AM +0800, Shawn Guo wrote:
> On Mon, Jan 30, 2012 at 05:46:14PM +0000, Dave Martin wrote:
> > Compiled device tree blobs shouldn't be committed in the kernel
> > tree, so ideally git should ignore them.
> > 
> > This patch will enable ignoring of any .dtb files which appear in
> > arch/arm/boot/
> > 
> > Signed-off-by: Dave Martin <dave.martin@linaro.org>
> 
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> 
> I added my ack tag on the same patch below, but it died in the end?
> 
> http://comments.gmane.org/gmane.linux.ports.arm.kernel/144097

I don't mind too much which patch goes in -- do we care about whether
other .dtb files can be included in the kernel?


I would suggest that it is just plain wrong for _binary_ devicetree
blobs to appear in the kernel tree, since there is a readily usable
source form for the same thing (this isn't firmware)

Do we think that the '.dtb' filename extension might get used foro
something else?

Cheers
---Dave

> 
> Regards,
> Shawn
> 
> > ---
> >  arch/arm/boot/.gitignore |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
> > index ce1c5ff..3c79f85 100644
> > --- a/arch/arm/boot/.gitignore
> > +++ b/arch/arm/boot/.gitignore
> > @@ -3,3 +3,4 @@ zImage
> >  xipImage
> >  bootpImage
> >  uImage
> > +*.dtb
> > -- 
> > 1.7.4.1
Dave Martin Jan. 31, 2012, 11:52 a.m. UTC | #3
On Tue, Jan 31, 2012 at 11:46:59AM +0000, Dave Martin wrote:
> On Tue, Jan 31, 2012 at 11:20:24AM +0800, Shawn Guo wrote:
> > On Mon, Jan 30, 2012 at 05:46:14PM +0000, Dave Martin wrote:
> > > Compiled device tree blobs shouldn't be committed in the kernel
> > > tree, so ideally git should ignore them.
> > > 
> > > This patch will enable ignoring of any .dtb files which appear in
> > > arch/arm/boot/
> > > 
> > > Signed-off-by: Dave Martin <dave.martin@linaro.org>
> > 
> > Acked-by: Shawn Guo <shawn.guo@linaro.org>
> > 
> > I added my ack tag on the same patch below, but it died in the end?
> > 
> > http://comments.gmane.org/gmane.linux.ports.arm.kernel/144097
> 
> I don't mind too much which patch goes in -- do we care about whether
> other .dtb files can be included in the kernel?
> 
> 
> I would suggest that it is just plain wrong for _binary_ devicetree
> blobs to appear in the kernel tree, since there is a readily usable
> source form for the same thing (this isn't firmware)
> 
> Do we think that the '.dtb' filename extension might get used foro
> something else?

Never mind, it looks like Grant merged my patch anyway.

Cheers
---Dave
diff mbox

Patch

diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
index ce1c5ff..3c79f85 100644
--- a/arch/arm/boot/.gitignore
+++ b/arch/arm/boot/.gitignore
@@ -3,3 +3,4 @@  zImage
 xipImage
 bootpImage
 uImage
+*.dtb