diff mbox series

crypto: p10-aes-gcm - Use _GLOBAL instead of .global

Message ID Y8UWHwTkKIkQn1t0@gondor.apana.org.au
State New
Headers show
Series crypto: p10-aes-gcm - Use _GLOBAL instead of .global | expand

Commit Message

Herbert Xu Jan. 16, 2023, 9:17 a.m. UTC 
On Mon, Jan 16, 2023 at 11:29:39AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the crypto tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> ERROR: modpost: ".aes_p10_gcm_decrypt" [arch/powerpc/crypto/p10-aes-gcm-crypto.ko] undefined!
> ERROR: modpost: ".aes_p10_gcm_encrypt" [arch/powerpc/crypto/p10-aes-gcm-crypto.ko] undefined!
> 
> Caused by commits
> 
>   cc40379b6e19 ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
>   ca68a96c37eb ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")

Does this patch help?

> I have used the crypto tree from next-20230113 for today.
> 
> BTW, that series seems to have been committed in the wrong order -
> there are refrerences to files/functions before they are created.

Sorry, this patch series was submitted in this order and I
didn't pick it up when applying it.

---8<---
_GLOBAL is needed instead of .global on Linux in assembly code.

Fixes: cc40379b6e19 ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks,
diff mbox series

Patch

diff --git a/arch/powerpc/crypto/p10_aes_gcm.S b/arch/powerpc/crypto/p10_aes_gcm.S
index 2306ad7c5e36..c25a1837efca 100644
--- a/arch/powerpc/crypto/p10_aes_gcm.S
+++ b/arch/powerpc/crypto/p10_aes_gcm.S
@@ -38,6 +38,8 @@ 
  # ===================================================================================
  #
 
+#include <asm/ppc_asm.h>
+
 .machine        "any"
 .abiversion     1
 .text
@@ -569,9 +571,8 @@  ppc_aes_gcm_ghash:
  #    rounds is at offset 240 in rk
  #    Xi is at 0 in gcm_table (Xip).
  #
-.global aes_p10_gcm_encrypt
 .align 5
-aes_p10_gcm_encrypt:
+_GLOBAL(aes_p10_gcm_encrypt)
 
 	SAVE_REGS
 
@@ -1109,9 +1110,8 @@  aes_gcm_out:
  #
  # 8x Decrypt
  #
-.global aes_p10_gcm_decrypt
 .align 5
-aes_p10_gcm_decrypt:
+_GLOBAL(aes_p10_gcm_decrypt)
 
 	SAVE_REGS