| Message ID | 20230116125144.36858-1-warthog618@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [libgpiod,v2] bindings: rust: fix documentation of line_request set_values | expand |
On Mon, Jan 16, 2023 at 1:51 PM Kent Gibson <warthog618@gmail.com> wrote: > > Replace "Get" with "Set". > > Signed-off-by: Kent Gibson <warthog618@gmail.com> > --- > Changes v1 -> v2: > - rebase on current master > > bindings/rust/libgpiod/src/line_request.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bindings/rust/libgpiod/src/line_request.rs b/bindings/rust/libgpiod/src/line_request.rs > index c16ec9f..d9e041c 100644 > --- a/bindings/rust/libgpiod/src/line_request.rs > +++ b/bindings/rust/libgpiod/src/line_request.rs > @@ -106,7 +106,7 @@ impl Request { > } > } > > - /// Get values of a subset of lines associated with the request. > + /// Set values of a subset of lines associated with the request. > pub fn set_values_subset(&self, map: ValueMap) -> Result<()> { > let mut offsets = Vec::new(); > let mut values = Vec::new(); > @@ -136,7 +136,7 @@ impl Request { > } > } > > - /// Get values of all lines associated with the request. > + /// Set values of all lines associated with the request. > pub fn set_values(&self, values: &[Value]) -> Result<()> { > if values.len() != self.num_lines() as usize { > return Err(Error::InvalidArguments); > -- > 2.39.0 > Applied, thanks! Bartosz
diff --git a/bindings/rust/libgpiod/src/line_request.rs b/bindings/rust/libgpiod/src/line_request.rs index c16ec9f..d9e041c 100644 --- a/bindings/rust/libgpiod/src/line_request.rs +++ b/bindings/rust/libgpiod/src/line_request.rs @@ -106,7 +106,7 @@ impl Request { } } - /// Get values of a subset of lines associated with the request. + /// Set values of a subset of lines associated with the request. pub fn set_values_subset(&self, map: ValueMap) -> Result<()> { let mut offsets = Vec::new(); let mut values = Vec::new(); @@ -136,7 +136,7 @@ impl Request { } } - /// Get values of all lines associated with the request. + /// Set values of all lines associated with the request. pub fn set_values(&self, values: &[Value]) -> Result<()> { if values.len() != self.num_lines() as usize { return Err(Error::InvalidArguments);
Replace "Get" with "Set". Signed-off-by: Kent Gibson <warthog618@gmail.com> --- Changes v1 -> v2: - rebase on current master bindings/rust/libgpiod/src/line_request.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)