| Message ID | 20230110170848.3022682-1-trix@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3] crypto: ccp: initialize 'error' variable to zero | expand |
On Tue, Jan 10, 2023 at 9:09 AM Tom Rix <trix@redhat.com> wrote: > > Clang static analysis reports this problem > drivers/crypto/ccp/sev-dev.c:1347:3: warning: 3rd function call > argument is an uninitialized value [core.CallAndMessage] > dev_err(sev->dev, "SEV: failed to INIT error %#x, rc %d\n", > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > __sev_platform_init_locked() can return without setting the > error parameter, causing the dev_err() to report a garbage > value. > > Fixes: 200664d5237f ("crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support") > Signed-off-by: Tom Rix <trix@redhat.com> Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > v2 cleanup commit log > v3 cleanup commit log > --- > drivers/crypto/ccp/sev-dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c > index 56998bc579d6..643cccc06a0b 100644 > --- a/drivers/crypto/ccp/sev-dev.c > +++ b/drivers/crypto/ccp/sev-dev.c > @@ -1307,7 +1307,7 @@ EXPORT_SYMBOL_GPL(sev_issue_cmd_external_user); > void sev_pci_init(void) > { > struct sev_device *sev = psp_master->sev_data; > - int error, rc; > + int error = 0, rc; > > if (!sev) > return; > -- > 2.27.0 > >
On Tue, Jan 10, 2023 at 12:08:48PM -0500, Tom Rix wrote: > Clang static analysis reports this problem > drivers/crypto/ccp/sev-dev.c:1347:3: warning: 3rd function call > argument is an uninitialized value [core.CallAndMessage] > dev_err(sev->dev, "SEV: failed to INIT error %#x, rc %d\n", > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > __sev_platform_init_locked() can return without setting the > error parameter, causing the dev_err() to report a garbage > value. > > Fixes: 200664d5237f ("crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support") > Signed-off-by: Tom Rix <trix@redhat.com> > --- > v2 cleanup commit log > v3 cleanup commit log > --- > drivers/crypto/ccp/sev-dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I think error should be removed completely on top of https://patchwork.kernel.org/project/linux-crypto/patch/20230110191201.29666-1-jarkko@profian.com/ Thanks,
diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 56998bc579d6..643cccc06a0b 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -1307,7 +1307,7 @@ EXPORT_SYMBOL_GPL(sev_issue_cmd_external_user); void sev_pci_init(void) { struct sev_device *sev = psp_master->sev_data; - int error, rc; + int error = 0, rc; if (!sev) return;
Clang static analysis reports this problem drivers/crypto/ccp/sev-dev.c:1347:3: warning: 3rd function call argument is an uninitialized value [core.CallAndMessage] dev_err(sev->dev, "SEV: failed to INIT error %#x, rc %d\n", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ __sev_platform_init_locked() can return without setting the error parameter, causing the dev_err() to report a garbage value. Fixes: 200664d5237f ("crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support") Signed-off-by: Tom Rix <trix@redhat.com> --- v2 cleanup commit log v3 cleanup commit log --- drivers/crypto/ccp/sev-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)