| Message ID | 20230113054304.21841-2-moudy.ho@mediatek.com |
|---|---|
| State | Accepted |
| Commit | dfea6ae346d7782bbe81696fe815e0f467d79e07 |
| Headers | show |
| Series | [v5,01/10] dt-bindings: arm: mediatek: migrate MT8195 vppsys0/1 to mtk-mmsys driver | expand |
On 16/01/2023 03:42, Moudy Ho (何宗原) wrote: > On Fri, 2023-01-13 at 12:58 +0100, Krzysztof Kozlowski wrote: >> On 13/01/2023 06:42, Moudy Ho wrote: >>> MT8195 vppsys0/1 should be probed from mtk-mmsys driver to >>> populate device by platform_device_register_data then start >>> its own clock driver. >> >> Unfortunately I don't understand why this justifies removal of >> compatibles. >> >> How do you propagate or instantiate devices is not really connected >> with >> the hardware description. >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > Refer to the comments of 0/8 and 1/8 in the following series: > https://patchwork.kernel.org/project/linux-mediatek/list/?series=702518 > > This patch is used in conjunction with another one(Message ID = > 20230113054304.21841-7-moudy.ho@mediatek.com/) to fix the binding > warnings caused by newly added in MMSYS. The patch should stand on its own. IOW, it should explain everything needed and it should justify its existence. Best regards, Krzysztof
On Mon, 2023-01-16 at 09:00 +0100, Krzysztof Kozlowski wrote: > On 16/01/2023 03:42, Moudy Ho (何宗原) wrote: > > On Fri, 2023-01-13 at 12:58 +0100, Krzysztof Kozlowski wrote: > > > On 13/01/2023 06:42, Moudy Ho wrote: > > > > MT8195 vppsys0/1 should be probed from mtk-mmsys driver to > > > > populate device by platform_device_register_data then start > > > > its own clock driver. > > > > > > Unfortunately I don't understand why this justifies removal of > > > compatibles. > > > > > > How do you propagate or instantiate devices is not really > > > connected > > > with > > > the hardware description. > > > > > > Best regards, > > > Krzysztof > > > > > > > Hi Krzysztof, > > > > Refer to the comments of 0/8 and 1/8 in the following series: > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=702518__;!!CTRNKA9wMg0ARbw!iR9oqyYsBrujnl_v5DEuDZrTGp75iBKkLK99KWQV391krqpZ_lK3d2Yr9MKxgROBuVgq2fnV9cFs7jzGwRjYX5_zjL0o$ > > > > > > This patch is used in conjunction with another one(Message ID = > > 20230113054304.21841-7-moudy.ho@mediatek.com/) to fix the binding > > warnings caused by newly added in MMSYS. > > The patch should stand on its own. IOW, it should explain everything > needed and it should justify its existence. > > Best regards, > Krzysztof > Hi Krzysztof, Thanks for the suggestion, I will split all related patches into another series. Sincerely, Moudy
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml index 17fcbb45d121..d62d60181147 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml @@ -28,11 +28,9 @@ properties: - mediatek,mt8195-imp_iic_wrap_s - mediatek,mt8195-imp_iic_wrap_w - mediatek,mt8195-mfgcfg - - mediatek,mt8195-vppsys0 - mediatek,mt8195-wpesys - mediatek,mt8195-wpesys_vpp0 - mediatek,mt8195-wpesys_vpp1 - - mediatek,mt8195-vppsys1 - mediatek,mt8195-imgsys - mediatek,mt8195-imgsys1_dip_top - mediatek,mt8195-imgsys1_dip_nr @@ -92,13 +90,6 @@ examples: #clock-cells = <1>; }; - - | - vppsys0: clock-controller@14000000 { - compatible = "mediatek,mt8195-vppsys0"; - reg = <0x14000000 0x1000>; - #clock-cells = <1>; - }; - - | wpesys: clock-controller@14e00000 { compatible = "mediatek,mt8195-wpesys"; @@ -120,13 +111,6 @@ examples: #clock-cells = <1>; }; - - | - vppsys1: clock-controller@14f00000 { - compatible = "mediatek,mt8195-vppsys1"; - reg = <0x14f00000 0x1000>; - #clock-cells = <1>; - }; - - | imgsys: clock-controller@15000000 { compatible = "mediatek,mt8195-imgsys";
MT8195 vppsys0/1 should be probed from mtk-mmsys driver to populate device by platform_device_register_data then start its own clock driver. Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> --- .../arm/mediatek/mediatek,mt8195-clock.yaml | 16 ---------------- 1 file changed, 16 deletions(-)