| Message ID | 20230112163825.72983-2-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/2] gpio: wcd934x: Remove duplicate assignment of of_gpio_n_cells | expand |
On Thu, Jan 12, 2023 at 5:38 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Since the only one and last user of the ->of_gpio_ranges_fallback() > gone, remove the callback completely. New platforms must use the > gpio-ranges property. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 72d8a3da31e3..266352b1a966 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -980,11 +980,6 @@ static int of_gpiochip_add_pin_range(struct gpio_chip *chip) if (!np) return 0; - if (!of_property_read_bool(np, "gpio-ranges") && - chip->of_gpio_ranges_fallback) { - return chip->of_gpio_ranges_fallback(chip, np); - } - group_names = of_find_property(np, group_names_propname, NULL); for (;; index++) { diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index ddc7a14a274f..29c283919f8a 100644 --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -522,17 +522,6 @@ struct gpio_chip { int (*of_xlate)(struct gpio_chip *gc, const struct of_phandle_args *gpiospec, u32 *flags); - /** - * @of_gpio_ranges_fallback: - * - * Optional hook for the case that no gpio-ranges property is defined - * within the device tree node "np" (usually DT before introduction - * of gpio-ranges). So this callback is helpful to provide the - * necessary backward compatibility for the pin ranges. - */ - int (*of_gpio_ranges_fallback)(struct gpio_chip *gc, - struct device_node *np); - #endif /* CONFIG_OF_GPIO */ };
Since the only one and last user of the ->of_gpio_ranges_fallback() gone, remove the callback completely. New platforms must use the gpio-ranges property. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpiolib-of.c | 5 ----- include/linux/gpio/driver.h | 11 ----------- 2 files changed, 16 deletions(-)